From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32643C5B56A for ; Tue, 11 Aug 2026 20:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hxGqZ8OqhiZUT9g5By3twhe2aIYif6OP6YW3nUAHHLw=; b=Km33FS6kODbZitzbl5aR95WfxN mprb9KaW/1jojJEWelDXbHQfGTdP9CcCo8j+YUjw25/zIFLSQbfUrRREHRiflxx5Wuk8dquVEghyg XtxOiTYeLH1Frfj+OrJ37hopAjd7Tm86py4KRySCqxGnOeBTf7pXbpf/AO/kzH0I683Q97g+4lhOW rcAiKrh9WGjrcKNYbHnHF9I7ECn4YoCdI5Kmwyk9k4MXPAoZsy5WcMwrbTs4CvMv4RN9qDdyfixps p5j8T2g97UhRDovT2HRBzdcUHyKBS6MYbowkND4/8CiPX378KNWtpJCqSKrZimSKi+j7eaTo/g8i9 v4+KAChA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtt6n-0000000EvVx-272q; Tue, 11 Aug 2026 20:30:01 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtt6m-0000000EvVQ-0Ko5 for linux-nvme@lists.infradead.org; Tue, 11 Aug 2026 20:30:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A920840936; Tue, 11 Aug 2026 20:29:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B1311F000E9; Tue, 11 Aug 2026 20:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786480198; bh=hxGqZ8OqhiZUT9g5By3twhe2aIYif6OP6YW3nUAHHLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LqjKCUEYCrsXAD0qSJw/TY2MKEaRvqIkdosgZe54vDIXlmqJJ+3GhQpRnyLGiQsp4 hCn4HL1vreO1yVzsLK56Y9fRaP4xbog6xxwr+g2C3NWL2HJHcwvkgKAc4+UGTS8RIP 1+mtxq2q+RFOLIvlIST+TIPE0FxRcHFviiuI8NVbtKqH2t8Vy/2otW1uB0Idcs8N8o LUTv6rZMFd4HWVj/fV5OJKtB87mw3N4eChi0Ze54qtLO49lKHPCn3xtXSF3KRBZMCp h9Fcl60+E+0tvJkPPPJzexn4urjzs0BPiTwiIK/yj0kXJscbEBbzOUnlQjJMkiOwYm SbCUA9YDcF7JQ== Date: Tue, 11 Aug 2026 14:29:56 -0600 From: Keith Busch To: changfengnan Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [RESEND RFC PATCH v2] nvme-pci: add adaptive interrupt polling Message-ID: References: <20260806031058.40176-1-changfengnan@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2026 at 10:32:35AM +0800, changfengnan wrote: > The code looks much cleaner when using dim, I'll see if I can replace the > sample-and-poll logic I wrote myself with the dim library.  > I ran a quick test on the POC patch and didn't see any performance > improvements; in fact, there were quite a few regressions. Maybe some > parameters need to be adjusted. Yeah, I'm just now testing mid-tier devices and it's also performing a bit worse for high throughput workloads. But I hadn't really tried to tune the settings here, and maybe my criteria is all wrong. I was mainly trying to see if we can utilize the dim library before honing in on the right implementation details.