Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Xixin Liu <liuxixin@kylinos.cn>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nvme-rdma: fix -EIO cleanup order in queue_rq
Date: Wed, 19 Aug 2026 09:32:38 -0600	[thread overview]
Message-ID: <aoXMlj33ku943CHm@kbusch-mbp> (raw)
In-Reply-To: <66b08bdf7d4d.v2.1787121041.git.liuxixin@kylinos.cn>

On Wed, Aug 19, 2026 at 02:30:00PM +0800, Xixin Liu wrote:
> On -EIO, the RDMA queue_rq path reports a host path error and then
> still cleans up the command and unmaps the SQE DMA. The path error
> helper completes the request, so that is double cleanup and DMA unmap
> after the request is already complete.
> 
> Unmap the SQE first, then report the host path error. Skip the outer
> command cleanup on that path.

Thanks, applied to nvme-7.3.


      parent reply	other threads:[~2026-08-19 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  9:45 [PATCH] nvme-rdma: fix -EIO cleanup order in queue_rq Xixin Liu
2026-08-19  5:45 ` Christoph Hellwig
2026-08-19  6:30 ` [PATCH v2 0/1] " Xixin Liu
2026-08-19  6:30   ` [PATCH v2 1/1] " Xixin Liu
2026-08-19  7:31     ` Christoph Hellwig
2026-08-19 15:32     ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoXMlj33ku943CHm@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=liuxixin@kylinos.cn \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox