From: Keith Busch <kbusch@kernel.org>
To: Mohamed Khalfella <mkhalfella@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: print namespace IDs as unsigned 32bit value
Date: Mon, 24 Aug 2026 18:56:09 -0600 [thread overview]
Message-ID: <aozoKQQDkNaEOhre@kbusch-mbp> (raw)
In-Reply-To: <20260821230310.3937527-1-mkhalfella@purestorage.com>
On Fri, Aug 21, 2026 at 04:03:09PM -0700, Mohamed Khalfella wrote:
> NSIDs are 32-bit unsigned values, but a number of log messages print
> them with %d. An NSID larger than 0x7fffffff is rendered as a negative
> number, which is confusing in the kernel log and makes the message hard
> to correlate with the namespace it talks about. Sparse NSID spaces
> where high NSIDs are common are the most likely to hit this.
>
> The nsid sysfs attribute has the same problem, and there it is worse
> because userspace parses the value.
Thanks, applied to nvme-7.3.
prev parent reply other threads:[~2026-08-25 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 23:03 [PATCH 1/2] nvme: print namespace IDs as unsigned 32bit value Mohamed Khalfella
2026-08-21 23:03 ` [PATCH 2/2] nvmet: " Mohamed Khalfella
2026-08-22 21:28 ` Sagi Grimberg
2026-08-22 21:28 ` [PATCH 1/2] nvme: " Sagi Grimberg
2026-08-25 0:56 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aozoKQQDkNaEOhre@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mkhalfella@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox