From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Nilay Shroff <nilay@linux.ibm.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@fb.com,
john.g.garry@oracle.com, wenxiong@linux.ibm.com,
gjoyce@linux.ibm.com
Subject: Re: [PATCH 1/2] nvme: keep transport module referenced while head node is open
Date: Wed, 2 Sep 2026 08:25:08 -0600 [thread overview]
Message-ID: <apgxxA6IwejAyAFJ@kbusch-mbp> (raw)
In-Reply-To: <20260902141347.GA24385@lst.de>
On Wed, Sep 02, 2026 at 04:13:47PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 02, 2026 at 07:39:32PM +0530, Nilay Shroff wrote:
> > So the practical problem is that an open multipath head can continue to
> > be used after its underlying transport module has been unloaded. The
> > proposed change keeps the transport module referenced while the head
> > node is open, preventing the module from being unloaded in this
> > scenario.
>
> But why do you unload it in the first place?
I don't think there's a use case to do it on purpose. It'd probably be
by mistake or mischief. This seems like a reasonable way to remove that
foot gun. We already do this for non-multipath, too.
next prev parent reply other threads:[~2026-09-02 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 15:19 [PATCH 0/2] nvme: add reference counting for transport modules Nilay Shroff
2026-08-31 15:19 ` [PATCH 1/2] nvme: keep transport module referenced while head node is open Nilay Shroff
2026-09-01 16:39 ` Keith Busch
2026-09-02 4:55 ` Nilay Shroff
2026-09-02 0:20 ` Wen Xiong
2026-09-02 13:31 ` Christoph Hellwig
2026-09-02 14:09 ` Nilay Shroff
2026-09-02 14:13 ` Christoph Hellwig
2026-09-02 14:25 ` Keith Busch [this message]
2026-09-02 14:27 ` Nilay Shroff
2026-09-13 14:03 ` Nilay Shroff
2026-08-31 15:19 ` [PATCH 2/2] nvme: add context annotation for nvme_ns_head::nr_openers Nilay Shroff
2026-09-01 8:14 ` [PATCH 0/2] nvme: add reference counting for transport modules John Garry
2026-09-01 9:47 ` Nilay Shroff
2026-09-01 10:14 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apgxxA6IwejAyAFJ@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox