From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: linux-nvme@lists.infradead.org
Cc: Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH blktests] common/nvme: do not truncate FULL file at nvme disconnect
Date: Thu, 3 Sep 2026 21:57:32 +0900 [thread overview]
Message-ID: <apluqlTcYccjkIF2@shinhome> (raw)
In-Reply-To: <20260828082721.2828731-1-shinichiro.kawasaki@wdc.com>
On Aug 28, 2026 / 17:27, Shin'ichiro Kawasaki wrote:
> Commit df7cf50409ce ("nvme: rely on nvme-cli status code") reworked the
> nvme-cli command error handling. As part of that change, the 'nvme
> disconnect' commands in _nvme_disconnect_ctrl() and
> _nvme_disconnect_subsys() were made to record their output in the FULL
> file using the '&>' redirect operator. However, '&>' truncates the file
> and so overwrites its existing content, wiping out the logs that each
> test case had already left in the FULL file.
>
> Use the '&>>' operator instead, which appends the command output while
> preserving the existing FULL file content.
>
> Fixes: df7cf50409ce ("nvme: rely on nvme-cli status code")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
FYI, I applied the patch.
prev parent reply other threads:[~2026-09-03 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 8:27 [PATCH blktests] common/nvme: do not truncate FULL file at nvme disconnect Shin'ichiro Kawasaki
2026-09-03 12:57 ` Shin'ichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apluqlTcYccjkIF2@shinhome \
--to=shinichiro.kawasaki@wdc.com \
--cc=dwagner@suse.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox