From: Keith Busch <kbusch@kernel.org>
To: Julian Sun <sunjunchao@bytedance.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, armenx.baloyan@intel.com,
james.p.freyensee@intel.com, ming.l@ssi.samsung.com
Subject: Re: [PATCH 1/2] nvmet: preserve device path on allocation failure.
Date: Fri, 11 Sep 2026 08:45:58 -0600 [thread overview]
Message-ID: <aqQUJtsY9JdGoVgb@kbusch-mbp> (raw)
In-Reply-To: <20260908033519.2721210-1-sunjunchao@bytedance.com>
On Tue, Sep 08, 2026 at 11:35:18AM +0800, Julian Sun wrote:
> nvmet_ns_device_path_store() frees the old path before allocating its
> replacement, losing the existing configuration if allocation fails.
> Allocate the new path before freeing the old one.
Thanks, applied to nvme-7.3.
prev parent reply other threads:[~2026-09-11 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 3:35 [PATCH 1/2] nvmet: preserve device path on allocation failure Julian Sun
2026-09-08 3:35 ` [PATCH 2/2] nvmet: reject enabling a namespace without a device path Julian Sun
2026-09-10 5:42 ` Christoph Hellwig
2026-09-10 5:47 ` Julian Sun
2026-09-10 5:25 ` [PATCH 1/2] nvmet: preserve device path on allocation failure Christoph Hellwig
2026-09-10 5:35 ` Julian Sun
2026-09-10 5:37 ` Christoph Hellwig
2026-09-10 5:42 ` Christoph Hellwig
2026-09-11 14:45 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqQUJtsY9JdGoVgb@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=armenx.baloyan@intel.com \
--cc=hch@lst.de \
--cc=james.p.freyensee@intel.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.l@ssi.samsung.com \
--cc=sagi@grimberg.me \
--cc=sunjunchao@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox