Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@opensource.wdc.com>,
	 linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	 Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	 Surabhi Gogte <sgogte@purestorage.com>
Subject: Re: [PATCH] nvmet-rdma: handle commands of established queue outside the CM handler
Date: Sun, 25 Oct 2026 21:54:38 +0900	[thread overview]
Message-ID: <at36um4zrsfOr3kh@shinmob> (raw)
In-Reply-To: <atvinQcDcpB7pzjK@kbusch-mbp>

On Oct 23, 2026 / 16:41, Keith Busch wrote:
...
> I think this might be a false positive. The handler_mutex taken in
> rdma_destroy_id() belongs to the listener, while the one held across
> ESTABLISHED belongs to the child cm_id. Is there ever an actual hang, or
> just the lockdep splat?

No, I just observed the WARN. So the WARN is likely a false positive as you
pointed out. I guess we can set different lockdep classes for the listener's
cm_ids and cm_ids for ESTABLISHED connections. Let me drop this patch and cook
something with the approach.


      reply	other threads:[~2026-10-25 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 12:44 [PATCH] nvmet-rdma: handle commands of established queue outside the CM handler Shin'ichiro Kawasaki
2026-10-23 22:41 ` Keith Busch
2026-10-25 12:54   ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at36um4zrsfOr3kh@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=hch@infradead.org \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=sgogte@purestorage.com \
    --cc=shinichiro.kawasaki@opensource.wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox