From: Keith Busch <kbusch@kernel.org>
To: Hugo Deco <hugodeco@sufficit.com.br>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me
Subject: Re: [PATCH] nvme: add NO_FUA quirk for ADATA XPG GAMMIX S70 BLADE
Date: Tue, 3 Nov 2026 08:32:24 -0700 [thread overview]
Message-ID: <aun-iBepyYhdGsZ5@kbusch-mbp> (raw)
In-Reply-To: <CAGFVba_mDRomduXFV5HugBvb9sKhNzdhgDvkCvUvcdOhy4ri4Q@mail.gmail.com>
On Thu, Oct 22, 2026 at 08:21:25AM -0700, Hugo Deco wrote:
> static const struct nvme_core_quirk_entry core_quirks[] = {
> + {
> + /*
> + * ADATA XPG GAMMIX S70 BLADE (fw 03020P5E) takes 200-600 ms
> + * to complete FUA writes while Flush takes ~1.3 ms.
> + */
> + .vid = 0x1cc1,
> + .mn = "XPG GAMMIX S70 BLADE",
> + .quirks = NVME_QUIRK_NO_FUA,
> + },
Can you add this to the nvme_id_table in the pci.c file instead? That
seems safer than matching a specific model string. There are several
other ADATA devices in that table, too.
prev parent reply other threads:[~2026-11-03 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 15:21 [PATCH] nvme: add NO_FUA quirk for ADATA XPG GAMMIX S70 BLADE Hugo Deco
2026-11-03 7:56 ` Christoph Hellwig
2026-11-03 15:32 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aun-iBepyYhdGsZ5@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=hugodeco@sufficit.com.br \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox