Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Hugo Deco <hugodeco@sufficit.com.br>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, andres@anarazel.de
Subject: Re: [PATCH v2] nvme-pci: add NO_FUA quirk for ADATA XPG GAMMIX S70 BLADE
Date: Wed, 4 Nov 2026 09:35:29 -0700	[thread overview]
Message-ID: <aute0dBvDO1asO9Y@kbusch-mbp> (raw)
In-Reply-To: <CAGFVba_n+Fhrp42X4Yn5hjBd=YWP-_2FVpCsxO_mogWGrfHd3w@mail.gmail.com>

On Tue, Nov 03, 2026 at 10:12:04AM -0800, Hugo Deco wrote:
> On the ADATA XPG GAMMIX S70 BLADE (PCI 1cc1:5370, firmware 03020P5E)
> every Write with the FUA bit set takes 200, 400 or 600 ms to complete,
> always a multiple of ~200 ms, while a plain Write completes in
> 0.0-0.4 ms and a Flush in ~1.3 ms. Tracing nvme_setup_cmd and
> nvme_complete_rq shows the whole delay is between submission and
> completion, i.e. inside the device (e.g. FUA write, control 0x4000:
> 598.3 ms).
> 
> Because ext4/jbd2 issue FUA for every journal commit, fsync() on this
> drive stalls for 250-890 ms and desktop applications freeze.
> 
> Add NVME_QUIRK_NO_FUA, which stops advertising BLK_FEAT_FUA while
> keeping the volatile write cache enabled, so the block layer emulates
> FUA with a Write followed by a Flush. Durability semantics are
> unchanged. Apply it to the S70 BLADE through nvme_id_table.

Thanks, applied to nvme-7.4.


      parent reply	other threads:[~2026-11-04 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 18:12 [PATCH v2] nvme-pci: add NO_FUA quirk for ADATA XPG GAMMIX S70 BLADE Hugo Deco
2026-11-04  7:19 ` Christoph Hellwig
2026-11-04 16:35 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aute0dBvDO1asO9Y@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=andres@anarazel.de \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=hugodeco@sufficit.com.br \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox