From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D31B606A329 for ; Wed, 4 Nov 2026 23:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wPjF+VJV; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Oac7osK6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=jLVIRJ1oNydBd8biicts5vct+iiNk9BFRv+VtPv5AgI=; b=wPjF+VJVT33/IkEArCeWf7zknD Q3D1l1I7ec1ev6csoXOQqC2dTNd6xWSCK8CunQJY6dPvhdQ6SJEEzlznOtjEvrJ4fik8+V5Fi1UK7 bNaSWHHzjiTz3GZ0YevpZdVYnGy9QNmlw6DEX5HzCXMsehHehJKKGSTGQC05ZwRmt8s8vE2hq4PDR uBXNYoKsRjYRVQ4BOqsrAsGG/QUHlPk6m5R7rVA300Enxq+13EgMh+k8JkNCyMhYd/vLv1S9Zqg2g X8mP8DEwsz1qAQ+OilrLkUB9FkpKbTKem037AtCL9PHla2JjT3eo/6w0s6joXHenZGgSVwOPxCA1S rRXEoPLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOkiY-00000007H0H-0z5c; Wed, 04 Nov 2026 23:48:34 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOkiX-00000007H00-1EiR for linux-nvme@lists.infradead.org; Wed, 04 Nov 2026 23:48:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with UTF8SMTP id 6C7BF601F7; Wed, 4 Nov 2026 23:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 9646B1F000C1; Wed, 4 Nov 2026 23:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793836112; bh=jLVIRJ1oNydBd8biicts5vct+iiNk9BFRv+VtPv5AgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Oac7osK6wKEvSA9uXr9NkmREaRoznEJucas6/qO91klzhIbVtSWzY3hcojw79o7Ah 67h9zLk6K1AYpIlvyyYM0ohbwQNicvpbw+qgWvmbneWzAEirKbSQ7WiAfeUGBoaHdf 61aS0HEYOzLOUx9HpcpDorRj/32SLJb9elvwRaCSuuc+TpuS10GCIjl036Hx6O8QB5 0/xddQibsa2PoSMRQTBlNQTbRcpSy1hQNu7C7zh84xQKPOSFY4BgyymjV5Ffjftwcj he7ChfHGXWXUuhJe6clS8RK8jl+R2hPs/NaTefGO/XZBVgZTAIbTSPE19n744Ono/K SVWDgEuODyblg== Date: Thu, 5 Nov 2026 01:48:28 +0200 From: Jarkko Sakkinen To: Keith Busch Cc: Christoph Hellwig , David Howells , Eric Biggers , linux-integrity@vger.kernel.org, Mimi Zohar , keyrings@vger.kernel.org, stable@vger.kernel.org, Jens Axboe , Sagi Grimberg , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Hannes Reinecke , "open list:NVM EXPRESS DRIVER" , open list , "open list:SECURITY SUBSYSTEM" Subject: Re: [RFC PATCH v2 02/11] nvme-keyring: Add a missing key_put() call to nvme_tls_key_lookup() Message-ID: References: <20261103030226.2685251-1-jarkko@kernel.org> <20261103030226.2685251-3-jarkko@kernel.org> <20261103053303.GA1382@lst.de> <20261104090440.GA30968@lst.de> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Nov 04, 2026 at 08:53:04AM -0700, Keith Busch wrote: > On Wed, Nov 04, 2026 at 04:43:09PM +0200, Jarkko Sakkinen wrote: > > On Wed, Nov 04, 2026 at 10:04:40AM +0100, Christoph Hellwig wrote: > > > On Tue, Nov 03, 2026 at 02:29:11PM +0200, Jarkko Sakkinen wrote: > > > > And essentially what I would want is key_type_dead not to exist. > > > > > > > > This version is based on module pinning, and thus not having that > > > > key_put() would keep key type module alive in that case. However, it > > > > turned out this approach will not fly as AF_RXRPC and DNS resolver will > > > > hit the wall given e.g., the remote pinnings. > > > > > > > > The approach I'm going for next is to have a type registry instead, > > > > which is independent of the module system (to put story really short). > > > > I think I'm doing this with right process as this really needs a few > > > > trials in order to find patterns that stick. > > > > > > So what's the plan here. Should we merge this standalone as a fix, > > > or are you trying to get an entire series in? > > > > > > If it's useful as a standalone fix, please resend it standalone. > > > > I'll send this as a standalone patch. > > I can just apply it as-is unless you plan to make any change from what > was submitted. Just future reference that the intention wasn't clear > when a series' recipients are split up this way. Yeah, I 100% agree with this. Br, Jarkko