Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH blktests 00/10] nvme: make NVME_TARGET_CONTROL work with remote targets
Date: Wed, 11 Nov 2026 19:36:31 +0900	[thread overview]
Message-ID: <avREkjfeJjzFg-0x@shinmob> (raw)
In-Reply-To: <20261104-nvme-target-control-v1-0-b31b40537bb4@suse.de>

On Nov 04, 2026 / 17:44, Daniel Wagner wrote:
> Running the nvme fabrics tests against a remote target with
> NVME_TARGET_CONTROL doesn't work in current upstream:
> 
> - contrib/nvme_target_control.py configures the target with nvmetcli
>   through a REST API which only exists in an nvmetcli branch that was
>   never merged, and its nvmetcli client crashes with configshell-fb 2.0.
>   The target is never set up and the tests fail to connect.
> 
> - With a target set up by other means, the tests pass without testing
>   anything: _nvme_ns_ready waits for the namespaces in the local nvmet
>   configfs, which doesn't exist for a remote target. _nvme_connect_subsys
>   returns an error after every connect, the tests skip their I/O and the
>   disconnect, and the harness reports leftover controllers.
> 
> - The tests which use more than one port configure the ports in the
>   local nvmet configfs, and add-ports is a stub. The authentication
>   tests change the host keys there too.

(snip)

Daniel, thank you for the series. I walked through the patches and all look
valuable. I applied first six patches. I made minor comments on the two patches
out of the left four patches. Please see if they make sense for you.


  parent reply	other threads:[~2026-11-11 10:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 16:44 [PATCH blktests 00/10] nvme: make NVME_TARGET_CONTROL work with remote targets Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 01/10] common/nvme: pass --ctrlkey to the target control script Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 02/10] common/nvme: wait for the namespace of a remote target Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 03/10] common/nvme: check the subsystem in _nvmet_target_add_ports Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 04/10] nvme: skip the tests which need the kernel target with a remote target Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 05/10] nvme/029: skip if the I/O exceeds the maximum transfer size Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 06/10] contrib: make nvme-target-control a standalone project Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 07/10] common/nvme: support the ports of a remote target Daniel Wagner
2026-11-11 10:30   ` Shin'ichiro Kawasaki
2026-11-04 16:44 ` [PATCH blktests 08/10] nvme/rc: change the host keys on " Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 09/10] nvme: skip the tests which need a feature the remote target lacks Daniel Wagner
2026-11-11 10:33   ` Shin'ichiro Kawasaki
2026-11-12  9:17     ` Daniel Wagner
2026-11-04 16:44 ` [PATCH blktests 10/10] contrib/nvme-target-control: add a NetApp ONTAP target Daniel Wagner
2026-11-11 10:36 ` Shin'ichiro Kawasaki [this message]
2026-11-12  9:19   ` [PATCH blktests 00/10] nvme: make NVME_TARGET_CONTROL work with remote targets Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avREkjfeJjzFg-0x@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox