From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, shinichiro.kawasaki@wdc.com,
hch@lst.de, sagi@grimberg.me
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: use srcu for namespace list reading
Date: Thu, 23 May 2024 10:18:36 -0600 [thread overview]
Message-ID: <b2840f20-5cdf-4e24-94a8-4898753067e1@kernel.dk> (raw)
In-Reply-To: <20240523155107.3612088-1-kbusch@meta.com>
On 5/23/24 9:51 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Iterate the namespace lists without taking a lock fixes potential
> pcircular lockdep complaints.
Change itself looks fine to me from a quick glance, however this commit
message is lacking (quite a bit). Please include a link and some more
detail on this, and why the SRCU approach will fix it.
--
Jens Axboe
prev parent reply other threads:[~2024-05-23 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 15:51 [PATCH] nvme: use srcu for namespace list reading Keith Busch
2024-05-23 16:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2840f20-5cdf-4e24-94a8-4898753067e1@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox