From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH RESEND v3 1/2] nvme-multipath: introduce service-time iopolicy
Date: Thu, 14 Nov 2024 10:53:03 +0000 [thread overview]
Message-ID: <b28f56ff-02ba-4fa0-9ee3-329fadac9997@nvidia.com> (raw)
In-Reply-To: <20241114084957.41787-2-kanie@linux.alibaba.com>
On 11/14/24 00:49, Guixin Liu wrote:
>
> +static struct nvme_ns *nvme_service_time_path(struct nvme_ns_head *head)
> +{
> + struct nvme_ns *opt = NULL, *nonopt = NULL, *ns;
> + unsigned int min_inflight_nonopt = UINT_MAX;
> + unsigned int min_inflight_opt = UINT_MAX;
> + unsigned int inflight;
> +
> + list_for_each_entry_rcu(ns, &head->list, siblings) {
> + if (nvme_path_is_disabled(ns))
> + continue;
> +
> + inflight = atomic64_read(&ns->ctrl->inflight_size);
atomic64_read has return type s64, is there any particular reason not to use
s64 ? OR
even u64 as it is used in many places in kernel ? OR
conversion from s64 to unsigned int is done intentionally ?
-ck
next prev parent reply other threads:[~2024-11-14 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 8:49 [PATCH RESEND v3 0/2] Introduce service-time multipath policy and document Guixin Liu
2024-11-14 8:49 ` [PATCH RESEND v3 1/2] nvme-multipath: introduce service-time iopolicy Guixin Liu
2024-11-14 10:53 ` Chaitanya Kulkarni [this message]
2024-11-15 1:42 ` Guixin Liu
2024-11-14 8:49 ` [PATCH RESEND v3 2/2] docs, nvme: add a nvme-multipath document Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28f56ff-02ba-4fa0-9ee3-329fadac9997@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox