From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH v3] nvmet-rdma: fix null dereference under heavy load
Date: Mon, 21 Jan 2019 09:46:02 -0600 [thread overview]
Message-ID: <b44f3efa-8a62-8a54-dfd9-ac36975e3f0f@opengridcomputing.com> (raw)
In-Reply-To: <ed249f9f-44f8-de1f-ba7e-1179317803d8@grimberg.me>
On 1/21/2019 3:10 AM, Sagi Grimberg wrote:
>> This looks ok to me:
>>
>> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> Applied to nvme-5.0
>
>> In the long run I wonder if we should get rid of the ?tatic
>> preallocation entirely and just use a free pool to avoid constant
>> reallocations..
>
> you mean a kmem_cache? very possible, we can also make the command
> struct to contain the rsp behind it to avoid the extra allocation...
Hey guys,
If every command struct requires a rsp, then it seems simpler to contain
it in the command struct.
My 2 cents...
Steve.
prev parent reply other threads:[~2019-01-21 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 17:35 [PATCH v3] nvmet-rdma: fix null dereference under heavy load Raju Rangoju
2019-01-03 23:13 ` Sagi Grimberg
2019-01-07 15:59 ` Steve Wise
2019-01-18 7:37 ` Raju Rangoju
2019-01-19 13:34 ` Christoph Hellwig
2019-01-21 9:10 ` Sagi Grimberg
2019-01-21 13:07 ` Max Gurtovoy
2019-01-21 15:46 ` Steve Wise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44f3efa-8a62-8a54-dfd9-ac36975e3f0f@opengridcomputing.com \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox