linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Daniel Wagner <dwagner@suse.de>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH rfc 6/6] nvme-fabrics: expose support for traddr as dns names to userspace
Date: Thu, 17 Aug 2023 13:37:12 +0300	[thread overview]
Message-ID: <b4fe7c1f-1581-bad2-9203-6f4c87d6a599@grimberg.me> (raw)
In-Reply-To: <cc448d32-f3f1-0929-18d4-15186adeac01@suse.de>


> [ .. ]
>>> So I figured that the current approach would be preferable if
>>> we accept how to expose that for a given kernel/driver, we can
>>> accept dns names, or we cannot.
>>>
>>> What do others think? Christoph? Keith? Chaitanya?
>>
>> Anyone has feedback here?
>>
>> Seems that we want this, but the question is how to expose
>> a new format of traddr (now can be a dns name) to userspace?
> 
> Or have a new token 'traddr_dns' (instaed of 'traddr'), which would
> hold the dnsname instead of the ip address.
> And reject inputs where both are set.
> Hmm?

I listed that as an option, you should read it.
There are some disadvantages in doing that, it needs to co-exist
with the mandatory (today) traddr, which is now will be mandatory
only for fc. And also now the user will need to decide a conflicting
existing functionality in nvme-cli that today accept dns names as
a format to traddr, but now will need a different argument for
passing it to the kernel.

Anyway, its possible, but more complicated IMO.

Plus, I also think that it can be useful for the kernel to signal
capabilities and support for things that are not only valid tokens.


  reply	other threads:[~2023-08-17 10:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  9:20 [PATCH rfc 0/6] support traddr as dns names for ip based transports Sagi Grimberg
2023-07-24  9:20 ` [PATCH rfc 1/6] nvme-fabrics: add helper to resolve ipv4/ipv6 or dns name Sagi Grimberg
2023-08-10 13:29   ` Hannes Reinecke
2023-08-13 12:54     ` Sagi Grimberg
2023-07-24  9:20 ` [PATCH rfc 2/6] nvme-tcp: use nvmf_resolve_address helper Sagi Grimberg
2023-08-10 13:30   ` Hannes Reinecke
2023-08-13 12:55     ` Sagi Grimberg
2023-07-24  9:20 ` [PATCH rfc 3/6] nvme-tcp: re-resolve traddr upon reconnect in case it is a dns name Sagi Grimberg
2023-08-10 13:30   ` Hannes Reinecke
2023-07-24  9:20 ` [PATCH rfc 4/6] nvme-rdma: use nvmf_resolve_address helper Sagi Grimberg
2023-08-10 13:31   ` Hannes Reinecke
2023-07-24  9:20 ` [PATCH rfc 5/6] nvme-rdma: re-resolve traddr upon reconnect in case it is a dns name Sagi Grimberg
2023-08-10 13:31   ` Hannes Reinecke
2023-07-24  9:20 ` [PATCH rfc 6/6] nvme-fabrics: expose support for traddr as dns names to userspace Sagi Grimberg
2023-08-10 13:33   ` Hannes Reinecke
2023-08-13 13:07     ` Sagi Grimberg
2023-08-17  9:11       ` Sagi Grimberg
2023-08-17  9:41         ` Hannes Reinecke
2023-08-17 10:37           ` Sagi Grimberg [this message]
2023-08-17 10:48             ` Hannes Reinecke
2023-08-17 11:09               ` Sagi Grimberg
2023-08-17 14:39                 ` Daniel Wagner
2023-08-20 10:55                   ` Sagi Grimberg
2023-08-21  6:08                     ` Daniel Wagner
2023-08-21  7:44                       ` Sagi Grimberg
2023-07-24  9:20 ` [PATCH rfc libnvme 7/6] fabrics: pass traddr dns name if the kernel supports it Sagi Grimberg
2023-08-10 12:03 ` [PATCH rfc 0/6] support traddr as dns names for ip based transports Sagi Grimberg
2023-08-10 12:33   ` Daniel Wagner
2023-08-10 13:24   ` Hannes Reinecke
2023-08-10 13:29   ` Belanger, Martin
2023-08-10 13:30     ` Belanger, Martin
2023-08-10 13:34 ` Hannes Reinecke
2023-08-13 13:09   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4fe7c1f-1581-bad2-9203-6f4c87d6a599@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).