From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Alon Zahavi <zahavi.alon@gmail.com>
Subject: Re: [Bug Report] NVMe-oF/TCP - Slab OOB Read in `nvmet_ctrl_find_get`
Date: Thu, 9 Nov 2023 08:49:52 +0000 [thread overview]
Message-ID: <b58a2dc6-cc8f-4d19-9efe-e1d5b4505efc@nvidia.com> (raw)
In-Reply-To: <20231109045222.GC28458@lst.de>
On 11/8/2023 8:52 PM, Christoph Hellwig wrote:
> On Wed, Nov 08, 2023 at 10:09:27PM +0000, Chaitanya Kulkarni wrote:
>> I specifically didn't send this patch when I wrote it initially, coz we are
>> modifying connect data and yes it will work just fine functionally but
>> in principal we should not touch connect data after nvmet_copy_from_sgl()
>> call even for the sake of debug prints or string comparison since it's
>> a data that we've received from host and should be in read-only mode.
>>
>> please correct me if connect data should not be treated as read-only...
>
> Why would it? It's purely in-memory and any data transfer is copied
> into it.
okay.
-ck
prev parent reply other threads:[~2023-11-09 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 13:37 [Bug Report] NVMe-oF/TCP - Slab OOB Read in `nvmet_ctrl_find_get` Alon Zahavi
2023-11-08 8:46 ` Chaitanya Kulkarni
2023-11-08 9:01 ` Alon Zahavi
2023-11-08 10:02 ` Chaitanya Kulkarni
2023-11-08 11:02 ` Alon Zahavi
2023-11-08 14:03 ` Christoph Hellwig
2023-11-08 22:09 ` Chaitanya Kulkarni
2023-11-09 4:52 ` Christoph Hellwig
2023-11-09 8:49 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b58a2dc6-cc8f-4d19-9efe-e1d5b4505efc@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=zahavi.alon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox