From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH 2/3] nvme-core: don't check non-mdts for disc ctrl
Date: Mon, 11 Apr 2022 10:49:40 +0000 [thread overview]
Message-ID: <b5dd1bb3-e001-ac66-d461-4d699a2dadd6@nvidia.com> (raw)
In-Reply-To: <34d61434-27cd-f918-a3bc-fdca3196ef99@grimberg.me>
>> I think we can skip the whole call to nvme_init_non_mdts_limits in this
>> case. And we should probably key it off having I/O queues to also
>> cover administrative controllers.
>
> I'd also move this check to the call-site instead of where it is now.
Okay, I'll add it to V2.
-ck
next prev parent reply other threads:[~2022-04-11 11:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 3:12 [PATCH 0/3] nvme: fix internal passthru error messages Chaitanya Kulkarni
2022-04-11 3:12 ` [PATCH 1/3] nvmet: handle admin default command set identifier Chaitanya Kulkarni
2022-04-11 6:18 ` Christoph Hellwig
2022-05-10 6:33 ` Christoph Hellwig
2022-04-11 3:12 ` [PATCH 2/3] nvme-core: don't check non-mdts for disc ctrl Chaitanya Kulkarni
2022-04-11 6:13 ` Christoph Hellwig
2022-04-11 10:27 ` Sagi Grimberg
2022-04-11 10:49 ` Chaitanya Kulkarni [this message]
2022-04-11 12:09 ` Chaitanya Kulkarni
2022-04-11 12:12 ` Christoph Hellwig
2022-04-11 12:40 ` Chaitanya Kulkarni
2022-04-11 14:14 ` Keith Busch
2022-04-11 20:44 ` Chaitanya Kulkarni
2022-04-11 23:51 ` Keith Busch
2022-05-10 6:21 ` Christoph Hellwig
2022-05-11 7:19 ` Chaitanya Kulkarni
2022-04-11 3:12 ` [PATCH 3/3] nvme-core: mark internal passthru req REQ_QUIET Chaitanya Kulkarni
2022-04-11 6:12 ` Christoph Hellwig
2022-04-11 10:48 ` Chaitanya Kulkarni
2022-04-11 10:28 ` Sagi Grimberg
2022-04-11 10:49 ` Chaitanya Kulkarni
2022-04-13 12:07 ` Yi Zhang
2022-04-15 5:59 ` Chaitanya Kulkarni
2022-04-13 16:48 ` Jonathan Derrick
2022-04-13 16:49 ` Jonathan Derrick
2022-04-13 16:52 ` Christoph Hellwig
2022-04-13 16:57 ` Jonathan Derrick
2022-04-13 17:09 ` Keith Busch
2022-04-13 17:11 ` Jonathan Derrick
2022-04-15 6:01 ` Chaitanya Kulkarni
2022-04-13 16:58 ` Keith Busch
2022-04-13 18:42 ` Alan Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dd1bb3-e001-ac66-d461-4d699a2dadd6@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox