From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v2 4/4] nvme: disable fabrics SQ flow control when asked by the user
Date: Wed, 14 Nov 2018 08:32:21 -0800 [thread overview]
Message-ID: <b6119c20-6b1e-e24c-baf3-a8e35c4a0355@grimberg.me> (raw)
In-Reply-To: <20181114142135.GC27204@infradead.org>
>> As for now, we don't care about sq_head pointer updates anyway, so
>> at least allow the controller to micro-optimize by omiting this update.
>>
>> Note that we will probably need to support it when a controller
>> that requires this comes along.
>
> Shouldn't we default to disabling control for any controller that
> supports it instead of adding an option?
We only know if the controller supports it from the discovery log entry
which is processed from userspace, and it does default to disable if
the controller supports it.
Would you prefer that the flag would be opposite? that would change the
existing behavior as Hannes indicated in the last version.
next prev parent reply other threads:[~2018-11-14 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:13 [PATCH v2 0/4] Support SQ flow control disabled mode (TP 8005) Sagi Grimberg
2018-10-03 8:13 ` [PATCH v2 1/4] nvmet: support fabrics sq flow control Sagi Grimberg
2018-11-14 14:19 ` Christoph Hellwig
2018-11-14 16:29 ` Sagi Grimberg
2018-10-03 8:13 ` [PATCH v2 2/4] nvmet: don't override treq upon modification Sagi Grimberg
2018-11-14 14:20 ` Christoph Hellwig
2018-11-14 16:30 ` Sagi Grimberg
2018-10-03 8:13 ` [PATCH v2 3/4] nvmet: expose support for fabrics SQ flow control disable in treq Sagi Grimberg
2018-10-03 8:13 ` [PATCH v2 4/4] nvme: disable fabrics SQ flow control when asked by the user Sagi Grimberg
2018-10-03 8:41 ` Hannes Reinecke
2018-11-14 14:21 ` Christoph Hellwig
2018-11-14 16:32 ` Sagi Grimberg [this message]
2018-10-03 8:13 ` [PATCH 5/4 nvme-cli] fabrics: support fabrics sq flow control disable Sagi Grimberg
2018-10-16 1:06 ` [PATCH v2 0/4] Support SQ flow control disabled mode (TP 8005) Sagi Grimberg
2018-10-31 5:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6119c20-6b1e-e24c-baf3-a8e35c4a0355@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).