From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, Amit.Engel@Dell.com,
kbusch@kernel.org
Subject: Re: [PATCH] nvme: print disposition on err req completion
Date: Thu, 8 Jun 2023 10:02:12 +0300 [thread overview]
Message-ID: <ba51ceb0-a257-392e-837d-f0899b6c6fd8@grimberg.me> (raw)
In-Reply-To: <20230608055320.GA11784@lst.de>
>>> Hmm, not sure this is the right way to approach it. I'd rather
>>> redo how the trace points work by having a class and the ondividual
>>> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.
>>
>> :)
>>
>> This was the original proposal (posted as a question to the list),
>> and I proposed this approach. You don't like it?
>
> 1) the different dispostitions are really very different events,
> lumping them up does make tracing harder because you need to
> manually filter every time
True.
> 2) I really don't like exposing the disposition enum outside of core.c
Don't think its much of an issue. But in any event I agree with having
different classes for easier tracing.
prev parent reply other threads:[~2023-06-08 7:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:49 [PATCH] nvme: print disposition on err req completion Chaitanya Kulkarni
2023-06-05 22:32 ` Sagi Grimberg
2023-06-07 5:00 ` Christoph Hellwig
2023-06-07 15:08 ` Sagi Grimberg
2023-06-07 17:06 ` Engel, Amit
2023-06-07 23:31 ` Chaitanya Kulkarni
2023-06-08 5:53 ` Christoph Hellwig
2023-06-08 7:02 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba51ceb0-a257-392e-837d-f0899b6c6fd8@grimberg.me \
--to=sagi@grimberg.me \
--cc=Amit.Engel@Dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).