public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers
Date: Tue, 25 May 2021 10:33:02 -0700	[thread overview]
Message-ID: <ba9c27c7-5eea-0c93-7b20-e6a5d48c9e02@gmail.com> (raw)
In-Reply-To: <20210525155946.2249322-1-sagi@grimberg.me>

On 5/25/2021 8:59 AM, Sagi Grimberg wrote:
> Transport drivers need both core and fabrics modules, instead of
> selecting both, have the selection transitive such that NVME_FABRICS
> selects NVME_CORE and transport drivers select NVME_FABRICS.
> 
> Suggested-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
>   drivers/nvme/host/Kconfig | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig

Agree...

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-05-25 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 15:59 [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers Sagi Grimberg
2021-05-25 17:33 ` James Smart [this message]
2021-05-25 20:17 ` Chaitanya Kulkarni
2021-08-16 16:47 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba9c27c7-5eea-0c93-7b20-e6a5d48c9e02@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox