* [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating
@ 2017-10-27 19:51 Keith Busch
2017-10-28 5:52 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Keith Busch @ 2017-10-27 19:51 UTC (permalink / raw)
Revalidating the disk needs to set the logical block format and capacity,
otherwise it can't figure out if the users modified anything about
the namespace.
Fixes: cdbff4f26bd9 ("nvme: remove nvme_revalidate_ns")
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 5a14cc7f28ee..37f9039bb9ca 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1249,6 +1249,7 @@ static int nvme_revalidate_disk(struct gendisk *disk)
goto out;
}
+ __nvme_revalidate_disk(disk, id);
nvme_report_ns_ids(ctrl, ns->ns_id, id, eui64, nguid, &uuid);
if (!uuid_equal(&ns->uuid, &uuid) ||
memcmp(&ns->nguid, &nguid, sizeof(ns->nguid)) ||
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating
2017-10-27 19:51 [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating Keith Busch
@ 2017-10-28 5:52 ` Christoph Hellwig
2017-10-29 12:25 ` Sagi Grimberg
2017-10-30 14:23 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-10-28 5:52 UTC (permalink / raw)
On Fri, Oct 27, 2017@01:51:22PM -0600, Keith Busch wrote:
> Revalidating the disk needs to set the logical block format and capacity,
> otherwise it can't figure out if the users modified anything about
> the namespace.
>
> Fixes: cdbff4f26bd9 ("nvme: remove nvme_revalidate_ns")
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
Looks fine to me:
Reviewed-by: Christoph Hellwig <hch at lst.de>
Jens: can you pick this up directly before sending a block PR today?
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating
2017-10-27 19:51 [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating Keith Busch
2017-10-28 5:52 ` Christoph Hellwig
@ 2017-10-29 12:25 ` Sagi Grimberg
2017-10-30 14:23 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2017-10-29 12:25 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating
2017-10-27 19:51 [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating Keith Busch
2017-10-28 5:52 ` Christoph Hellwig
2017-10-29 12:25 ` Sagi Grimberg
@ 2017-10-30 14:23 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-10-30 14:23 UTC (permalink / raw)
On 10/27/2017 01:51 PM, Keith Busch wrote:
> Revalidating the disk needs to set the logical block format and capacity,
> otherwise it can't figure out if the users modified anything about
> the namespace.
Applied, thanks Keith.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-30 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 19:51 [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating Keith Busch
2017-10-28 5:52 ` Christoph Hellwig
2017-10-29 12:25 ` Sagi Grimberg
2017-10-30 14:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).