From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@kernel.dk (Jens Axboe) Date: Wed, 5 Sep 2018 13:54:31 -0600 Subject: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests In-Reply-To: <20180905195647.GA1626@lst.de> References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> Message-ID: On 9/5/18 1:56 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018@01:45:04PM -0600, Jens Axboe wrote: >> The point is that the caller doesn't necessarily know where the bio >> will end up, hence the caller can't fully check if the whole stack >> supports P2P. > > The caller must necessarily know where the bio will end up, as for P2P > support we need to query if the bio target is P2P capable vs the > source of the P2P memory. Then what's the point of having the check at all? -- Jens Axboe