From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org, bmarzins@redhat.com
Subject: Re: [PATCH] nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs
Date: Fri, 15 May 2026 09:34:30 +0100 [thread overview]
Message-ID: <bea351b2-2cfe-4a3c-b2ad-7185b29a4af3@oracle.com> (raw)
In-Reply-To: <20260515044529.GA4003@lst.de>
On 15/05/2026 05:45, Christoph Hellwig wrote:
> On Wed, May 13, 2026 at 09:50:30AM +0000, John Garry wrote:
>> Use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE instead of
>> DEFINE_SYSFS_GROUP_VISIBLE, which means that we can drop
>> multipath_sysfs_attr_visible().
>>
>> Incidentally, multipath_sysfs_attr_visible() should have returned a
>> umode_t.
>
> Looks ok, although all the magic symbol name concatenation in the
> sysfs code drives me a bit crazy.
yeah, lots of #/## from those sysfs helpers
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by?
cheers
next prev parent reply other threads:[~2026-05-15 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:50 [PATCH] nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs John Garry
2026-05-15 4:45 ` Christoph Hellwig
2026-05-15 8:34 ` John Garry [this message]
2026-05-15 11:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bea351b2-2cfe-4a3c-b2ad-7185b29a4af3@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@fb.com \
--cc=bmarzins@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox