Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: james.smart@broadcom.com (James Smart)
Subject: nvme-fc unregister remote port
Date: Thu, 18 Jan 2018 08:18:28 -0800	[thread overview]
Message-ID: <bf30c864-30b5-8333-add8-df3483b318a0@broadcom.com> (raw)
In-Reply-To: <47091667-53B5-4F7D-B244-D3A1A1C6D629@cavium.com>

On 1/18/2018 7:54 AM, Trapp, Darren wrote:
> 	If you're concerned about driver unload or reset paths - where the
>         target is present up to that point, I guess it could be better behaved.
>      	I don't know that it's mandatory as initiator and target have to manage
>      	the surprise removal cases.
>
> Looking at your proposed text for in T11-2017-00419-v001.pdf it will be mandatory:
>
> An initiator NVMe_Port shall perform the following steps to terminate an NVMeoFC association:
>         1) transmit an ABTS-LS (see 11.3) for all open Exchanges for the NVMeoFC association being
>         terminated, except for a Disconnect NVMe_LS Exchange.
>         2) transmit a Disconnect NVMe_LS request to the corresponding target NVMe_Port unless there
>         is no valid login with the associated NVMe_Port. The Disconnect NVMe_LS request, if
>         transmitted, shall contain an Association Identifier descriptor with the Association Identifier of
>         the NVMeoFC association being terminated.

True - but: does deregister mean the target is not there thus the login 
is gone ??? Even with unload, you will be logging out - at what point 
did the logout occur ?

I'll look into whether we can do something to be a bit more graceful for 
the controlled shutdown flows where login can be delayed.

-- james

  reply	other threads:[~2018-01-18 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 22:25 nvme-fc unregister remote port Trapp, Darren
2018-01-12 23:23 ` James Smart
2018-01-18 15:54   ` Trapp, Darren
2018-01-18 16:18     ` James Smart [this message]
2018-01-18 16:23       ` Trapp, Darren
2018-01-18 16:44         ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf30c864-30b5-8333-add8-df3483b318a0@broadcom.com \
    --to=james.smart@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox