From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH 1/1] block: move sector bio member into blk_next_bio()
Date: Tue, 8 Mar 2022 23:19:01 +0000 [thread overview]
Message-ID: <bf552863-ae22-e614-9abb-07a884a70130@nvidia.com> (raw)
In-Reply-To: <20220301112527.GA2567@lst.de>
On 3/1/22 03:25, Christoph Hellwig wrote:
> It would be nice to just calculate the sector from the previous
> bio using bio_end_sector, but that doesn't really work with the
> current blk_next_bio pattern. It might make sense to just take the
> initial allocation case out of blk_next_bio and do that manually now
> that the bio_alloc interface makes a lot more sense.
>
I found existing pattern easier to read with blk_next_bio(),
as removal of blk_next_bio() will result in the duplication of code for
allocation which blk_next_bio() avoids, unless I didn't understand your
comment.
-ck
prev parent reply other threads:[~2022-03-08 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 2:23 [PATCH 0/1] block: move sector bio member into blk_next_bio() Chaitanya Kulkarni
2022-03-01 2:23 ` [PATCH 1/1] " Chaitanya Kulkarni
2022-03-01 11:25 ` Christoph Hellwig
2022-03-08 23:19 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf552863-ae22-e614-9abb-07a884a70130@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox