From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1802BC46CD2 for ; Wed, 24 Jan 2024 06:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RW4O677P8gtxdk1h9zpLLUk4t3hUWTGqLL0uyRMks7E=; b=dP/xdF7L1J1niAaSEOwiqVtJwy KXeMDHCXTqhu3kaiZiMAjZpHpi08d//MjSuB7J1Yg7uL4tFiplEXrlHyp7iCjwj0FgfjlcBGanex1 4Ap1F1fEu8smq8g9z8fJ3OGU3Er69+cqRt240sTxpYNITc6dHEaNrN1REBpPpD+ILmL0s0nkCEEuy nv3e8BKgwqr5fYLD+DSoQznnv0f4RkKLF95JzfRAqMZk7qasygIaGMcCdhyj9b59+6H7g38FT0hIl +c2X9zjILrgEMFe4Gz7gnTIMtIPrQiDtRlSa7jYmBkpkeX98Dez7x19sTBj0emMpR31RBv2WzbAx0 Cx9zhDPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSWba-001ihT-2j; Wed, 24 Jan 2024 06:19:22 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSWbX-001ign-2D for linux-nvme@lists.infradead.org; Wed, 24 Jan 2024 06:19:21 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E9B5E21F28; Wed, 24 Jan 2024 06:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706077158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW4O677P8gtxdk1h9zpLLUk4t3hUWTGqLL0uyRMks7E=; b=Vd/jE7pi8w65FMo3skquaiEQNjaZXmE7Zb/bCeze0F8I0QyBy8CiVg5N5nnJdlUzBnvEng 6ci5RS+NJN9nvQoaQfhGj2FT5GiNHoN4itAwg3uCQWo6cE98Wei/aNZnjRyS40be44393T E2HAceD8mVDcGFA5NdeS/97diTURHrA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706077158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW4O677P8gtxdk1h9zpLLUk4t3hUWTGqLL0uyRMks7E=; b=dvF8Y2Tl43DwuMvo1AvjgQB99izfscSJ2RLrqAoDazFr4/Jkbx1iU4JEo1vqJTdPXJdFSy 7HEqOerceXdfcpDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706077157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW4O677P8gtxdk1h9zpLLUk4t3hUWTGqLL0uyRMks7E=; b=i/0Ot2XbM+XbItbqLbL/CXx/hoZOolQJBDDLF6PuEp7Qu3p7dTclhlsHkYeqrrnKmfwVIQ wyDSWIifFZm138dA7vnhFZ5PN3g6lKpYyOPNINhCQGJHbMxXBP7gghMeZRjJOpBzLYKOU2 G8j8yrwAxabanrMGDhpJGKWGxnhT7Jw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706077157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW4O677P8gtxdk1h9zpLLUk4t3hUWTGqLL0uyRMks7E=; b=NGw/m7EwGzYLrA/2WhR1m88FJ+GnOiU8OCql8Ql8cEoq6QkYk3sYOJGtABqiHOZ82IpoJf RfHz+XjbsRaLFbBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4D4AA1333E; Wed, 24 Jan 2024 06:19:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id fn5LEOWrsGU4SQAAD6G6ig (envelope-from ); Wed, 24 Jan 2024 06:19:17 +0000 Message-ID: Date: Wed, 24 Jan 2024 07:19:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/15] virtio_blk: split virtblk_probe Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Paolo Bonzini , Stefan Hajnoczi , "Martin K. Petersen" , Damien Le Moal , Keith Busch , Sagi Grimberg , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, virtualization@lists.linux.dev References: <20240122173645.1686078-1-hch@lst.de> <20240122173645.1686078-12-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20240122173645.1686078-12-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="i/0Ot2Xb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="NGw/m7Ew" X-Spamd-Result: default: False [-4.33 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.53)[97.89%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWELVE(0.00)[14]; DBL_BLOCKED_OPENRESOLVER(0.00)[lst.de:email,suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: E9B5E21F28 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_221919_875701_E5D6A1EA X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/22/24 18:36, Christoph Hellwig wrote: > Split out a virtblk_read_limits helper that just reads the various > queue limits to separate it from the higher level probing logic. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/virtio_blk.c | 193 +++++++++++++++++++------------------ > 1 file changed, 101 insertions(+), 92 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich