Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme-rdma: remove redundant reference between ib_device and tagset
Date: Sun, 12 May 2019 08:26:22 -0700	[thread overview]
Message-ID: <c162fcdf-9ae5-93bb-e1f2-5179acef3083@grimberg.me> (raw)
In-Reply-To: <1557139675-2469-1-git-send-email-maxg@mellanox.com>

This looks good max.

On 5/6/19 3:47 AM, Max Gurtovoy wrote:
> In the past, before adding f41725bb ("nvme-rdma: Use mr pool") commit,
> we needed a reference on the ib_device as long as the tagset
> was alive, as the MRs in the request structures needed a valid ib_device.
> Now, we allocate/deallocate MR pool per QP and consume on demand.
> 
> Also remove nvme_rdma_free_tagset function and use blk_mq_free_tag_set
> instead, as it unneeded anymore.
> 
> This commit also fixes a memory leakage and possible segmentation fault.
> When configuring the system with NIC teaming (aka bonding)

Question, what about sqe dma mappings? don't they need to be remapped as
well?

  parent reply	other threads:[~2019-05-12 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 10:47 [PATCH] nvme-rdma: remove redundant reference between ib_device and tagset Max Gurtovoy
2019-05-08  7:17 ` Christoph Hellwig
2019-05-12 15:26 ` Sagi Grimberg [this message]
2019-05-14 10:30   ` Max Gurtovoy
2019-05-14 11:18     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c162fcdf-9ae5-93bb-e1f2-5179acef3083@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox