Re: [PATCH 1/3] nvmet: expose discovery subsystem in sysfs

[Hannes Reinecke <hare@suse.de>]

On 3/15/22 12:15, Sagi Grimberg wrote:
> 
[ .. ]
>> When you want to retrieve the discovery log manually _and_ have 
>> existing persistent discovery controllers you'll need to know which 
>> device to pick.
> 
> Please describe the use-case because I still don't understand.
> nvme-cli offers 'discover' that gives you the log page and 'connect-all'
> that connects to the subsystems it found in the log page.
> 
> Do you have foreign udev rules in addition to the ones supplied in
> nvme-cli? I am missing the problem statement that you are alluding to.
> 

No, not foreign rules; it's the manual call to 'nvme discover' which I 
try to simplify.

But you are right; unique discovery controllers are only important for 
authentication. Everything else is just to make the system 'nicer'.

So leave it for now and I'll come back with a different set of patches, 
as I _still_ see a benefit in being able to configure the discovery 
response.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer