From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Weiwen Hu <huweiwen@linux.alibaba.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>
Cc: Mike Christie <michael.christie@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/4] nvme: fix status magic numbers
Date: Wed, 5 Jun 2024 00:02:19 +0000 [thread overview]
Message-ID: <c680bbd2-2b8d-4d99-9e5e-51b4e922612a@nvidia.com> (raw)
In-Reply-To: <20240603125702.97368-3-huweiwen@linux.alibaba.com>
On 6/3/24 05:57, Weiwen Hu wrote:
> Replaced some magic numbers about SC and SCT with enum and macro.
>
> Signed-off-by: Weiwen Hu <huweiwen@linux.alibaba.com>
> ---
[...]
> @@ -1223,7 +1223,7 @@ EXPORT_SYMBOL_NS_GPL(nvme_passthru_end, NVME_TARGET_PASSTHRU);
>
> /*
> * Recommended frequency for KATO commands per NVMe 1.4 section 7.12.1:
> - *
> + *
> * The host should send Keep Alive commands at half of the Keep Alive Timeout
> * accounting for transport roundtrip times [..].
> */
looks bit odd to have in this patch without the commit log,
but if everyone is okay ignore this comment, Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-06-05 0:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:56 [PATCH v2 0/4] clarify NVMe status symbol names Weiwen Hu
2024-06-03 12:56 ` [PATCH v2 1/4] nvme: rename nvme_sc_to_pr_err to nvme_status_to_pr_err Weiwen Hu
2024-06-04 23:57 ` Chaitanya Kulkarni
2024-06-05 8:54 ` Sagi Grimberg
2024-06-03 12:57 ` [PATCH v2 2/4] nvme: fix status magic numbers Weiwen Hu
2024-06-05 0:02 ` Chaitanya Kulkarni [this message]
2024-06-05 8:55 ` Sagi Grimberg
2024-06-03 12:57 ` [PATCH v2 3/4] nvme: rename CDR/MORE/DNR to NVME_STATUS_* Weiwen Hu
2024-06-05 0:03 ` Chaitanya Kulkarni
2024-06-05 8:55 ` Sagi Grimberg
2024-06-03 12:57 ` [PATCH v2 4/4] mailmap: add entry for Weiwen Hu Weiwen Hu
2024-06-04 4:25 ` [PATCH v2 0/4] clarify NVMe status symbol names Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c680bbd2-2b8d-4d99-9e5e-51b4e922612a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=huweiwen@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox