linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] nvme-pci: simplify __nvme_submit_cmd
Date: Sat, 26 May 2018 06:54:18 -0600	[thread overview]
Message-ID: <c830723e-ee63-12a0-a794-3946293d5fb0@kernel.dk> (raw)
In-Reply-To: <20180526114555.8881-1-hch@lst.de>

On 5/26/18 5:45 AM, Christoph Hellwig wrote:
> With recent CQ handling improvements we can now move the locking into
> __nvme_submit_cmd.  Also remove the local tail variable to make the code
> more obvious, remove the __ prefix in the name, and fix the comments
> describing the function.

Looks good to me.

Reviewed-by: Jens Axboe <axboe at kernel.dk>

-- 
Jens Axboe

  reply	other threads:[~2018-05-26 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 11:45 [PATCH] nvme-pci: simplify __nvme_submit_cmd Christoph Hellwig
2018-05-26 12:54 ` Jens Axboe [this message]
2018-05-28 13:12 ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c830723e-ee63-12a0-a794-3946293d5fb0@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).