From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 1/3] nvme: 002: fix nvmet pass data with loop
Date: Tue, 7 May 2019 05:13:01 +0900 [thread overview]
Message-ID: <c86fe09e-9964-123a-bc17-e9b9e6a80856@gmail.com> (raw)
In-Reply-To: <SN6PR04MB4527FAD8076A5A5610F6B66786300@SN6PR04MB4527.namprd04.prod.outlook.com>
> I wasn't clear enough.
>
> It doesn't check for the return value for now. What needs to happen is :-
>
> 1. Get rid of the variable strings which are not part of the discovery
> log page entries such as Generation counter.
> 2. Validate each log page entry content.
Question again here.
Do you mean that log page entry contents validation should be in bash
level instead of *.out comparison?
> 3. Check the return value.
nvme-cli is currently returning value like:
> 0 : failed with nvme status code (but the actual value may not be
the same with status)
== 0 : done successfully
< 0 : failed with -errno
But, ( > 0) case may be removed from nvme-cli soon due to [1] discuss.
Anyway, if nvme-cli is going to return 0 for both cases: success, error
with nvme status, then test case is going to be hard to check the error
status by a return value. It should be with output string parsing which
would be great if it's going to be commonized.
[1] https://github.com/linux-nvme/nvme-cli/pull/492
next prev parent reply other threads:[~2019-05-06 20:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 15:06 [PATCH 0/3] blktests: nvme: Fix pass data of nvmet TCs Minwoo Im
2019-05-05 15:06 ` [PATCH 1/3] nvme: 002: fix nvmet pass data with loop Minwoo Im
2019-05-06 16:25 ` Chaitanya Kulkarni
2019-05-06 16:38 ` Minwoo Im
2019-05-06 16:46 ` Chaitanya Kulkarni
2019-05-06 16:54 ` Minwoo Im
2019-05-06 17:47 ` Chaitanya Kulkarni
2019-05-06 20:13 ` Minwoo Im [this message]
2019-05-06 23:01 ` Chaitanya Kulkarni
2019-05-06 23:23 ` Minwoo Im
2019-05-07 1:38 ` Chaitanya Kulkarni
2019-05-09 5:51 ` Chaitanya Kulkarni
2019-05-09 6:15 ` Minwoo Im
2019-05-07 6:20 ` Johannes Thumshirn
2019-05-07 10:23 ` Minwoo Im
2019-05-09 5:52 ` Chaitanya Kulkarni
2019-05-05 15:06 ` [PATCH 2/3] nvme: 016: " Minwoo Im
2019-05-06 16:26 ` Chaitanya Kulkarni
2019-05-05 15:06 ` [PATCH 3/3] nvme: 017: " Minwoo Im
2019-05-06 16:25 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c86fe09e-9964-123a-bc17-e9b9e6a80856@gmail.com \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox