From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD65C1975A for ; Tue, 17 Mar 2020 22:50:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6B3F20714 for ; Tue, 17 Mar 2020 22:50:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RZEmryd4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B3F20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxi6C4dvOPCoShI3U+uqB84wGtkQ4VkpO5lrhrUEY7w=; b=RZEmryd4uILaCS s7fqHyTZOIzoMC2rFxFfpA/PNdMq9LCR87UQ7Hnd44x53/OqJf8tP4fssV5nIZE8V5UauriZDeEIt 4xj259yzAWbsEL9/FqyTUnBU5izaWmtln+wRIdjUQmmR2vOepWQd4aZu5+Z1u6sVRslATIvIPPBw0 uEHD9bxCtMla/K0kniVhHcwhe731Kp/nljWE87RtYqejHd1DYyNVyTB4vYaNB3oT0kAOuLsV7EnvV ADjAZcwQdgQ3YgZj96dj3qEyBg6L3d66Nz+FGdRfXoiPc/3sbPsq3U4gXx064tJSQ4/ALPg2BC7S9 S5LkClBpJdIy1J37n5RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEL2I-0006qi-GE; Tue, 17 Mar 2020 22:50:10 +0000 Received: from mail-pg1-f196.google.com ([209.85.215.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEL2F-0006OR-88 for linux-nvme@lists.infradead.org; Tue, 17 Mar 2020 22:50:08 +0000 Received: by mail-pg1-f196.google.com with SMTP id m5so12540586pgg.0 for ; Tue, 17 Mar 2020 15:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5hBg2UInqixDNtz8m0CWKvWrEprkNxjnjLnmqE6peRY=; b=cgFveGKvbXszb3PDRPq/T0yf78KfYuGsB3EGleLr34erhw9wtvkCFq+NpXNYnvc/1s 0ZrlgSBhS6pQZdr5/2d+MElsfxAUS0IO4MnwIci4j/K2EJ9pqc2zEVDDOuUQH9eC90O3 7T3ELmpfVZ2rM3xLukmaCQIkSK6/wWmtvna1lbffKM3ZV3C/V9RCY6x5Z+flQ+d2eyM2 /cdgIzJA0R4jbZcNCs8tR+qYjImC6BqNmYO6dJ3k4u0csNd1uiXrZz2w+GTaKe2ilaWN 95FH3XYigXqyN12DgK1OAOM8inL4ouzPFh6z0XNgXGo9USi+9rscDHckyX5oIJmdejkM mPvA== X-Gm-Message-State: ANhLgQ16flRFMM4jJ/nPAKFlGyQr4T7LG7nlN1RtJ93B26E4E3dYXzbT z4w/cUWBRdD44A82vj3ziBo= X-Google-Smtp-Source: ADFU+vsYTjDoZEcwmb5AYdgQkBYd0HDAqlu60fFz42fJwFGtgidjsPtmvvKSHiGbbiMTZfNQxSijYw== X-Received: by 2002:a63:ec50:: with SMTP id r16mr1568610pgj.274.1584485406022; Tue, 17 Mar 2020 15:50:06 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:a8f7:65f:9d45:d2f4? ([2601:647:4000:d7:a8f7:65f:9d45:d2f4]) by smtp.gmail.com with ESMTPSA id 64sm4266798pfd.48.2020.03.17.15.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2020 15:50:04 -0700 (PDT) Subject: Re: [PATCH 4/5] IB/core: cache the CQ completion vector To: Max Gurtovoy , Chuck Lever References: <20200317134030.152833-1-maxg@mellanox.com> <20200317134030.152833-5-maxg@mellanox.com> <448195E1-CE26-4658-8106-91BAFF115853@gmail.com> <078fd456-b1bc-a103-070b-d1a8ea6bff9c@mellanox.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Tue, 17 Mar 2020 15:50:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <078fd456-b1bc-a103-070b-d1a8ea6bff9c@mellanox.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200317_155007_300323_D5B6CAAC X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: loberman@redhat.com, sagi@grimberg.me, vladimirk@mellanox.com, idanb@mellanox.com, linux-rdma@vger.kernel.org, shlomin@mellanox.com, linux-nvme@lists.infradead.org, leonro@mellanox.com, dledford@redhat.com, jgg@mellanox.com, Oren Duer , kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2020-03-17 08:41, Max Gurtovoy wrote: > On 3/17/2020 5:19 PM, Chuck Lever wrote: >> If you want to guarantee that there is an SRQ for each comp_vector and a >> comp_vector for each SRQ, stick with a CQ allocation API that enables >> explicit selection of the comp_vector value, and cache that value in the >> caller, not in the core data structures. > > I'm Ok with that as well. This is exactly what we do in the nvmf/rdma > but I wanted to stick also with the SRP target approach. > > Any objection to remove the call for ib_alloc_cq_any() from ib_srpt and > use ib_alloc_cq() ? Hi Max, Wasn't that call introduced by Chuck (see also commit 20cf4e026730 ("rdma: Enable ib_alloc_cq to spread work over a device's comp_vectors") # v5.4)? Anyway, I'm fine with the proposed change. Thanks, Bart. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme