From: Sagi Grimberg <sagi@grimberg.me>
To: Tokunori Ikegami <ikegami.t@gmail.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging
Date: Sun, 5 May 2024 16:46:48 +0300 [thread overview]
Message-ID: <cb2c0d9a-7f45-44d0-bb4d-e074870966f2@grimberg.me> (raw)
In-Reply-To: <20240505120324.20858-1-ikegami.t@gmail.com>
> requeue:
> - dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d\n",
> - ctrl->ctrl.nr_reconnects);
> + dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d of %d\n",
> + ctrl->ctrl.nr_reconnects, ctrl->ctrl.opts->max_reconnects);
How about we do:
"Failed reconnect attempt %d/%d\n"
And the same for the successful reconnect:
"Successfully reconnected (attempt %d/%d)\n"
next prev parent reply other threads:[~2024-05-05 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 12:03 [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging Tokunori Ikegami
2024-05-05 13:46 ` Sagi Grimberg [this message]
2024-05-05 15:27 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2c0d9a-7f45-44d0-bb4d-e074870966f2@grimberg.me \
--to=sagi@grimberg.me \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox