From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D4B4C25B75 for ; Thu, 23 May 2024 10:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hXFkJ8d8gv22e48RVMGd5BeV2r93UQI+UE+HOEciU/8=; b=SI96MX9T5Qc1omI4SFMtMmrUv5 J2EQM42et0LLGjPdTEQoSGeO0qWFvtaXZHJe5G83Q1/++r9UiZYMF1v9vVl52VCY+EmA5o0dgZuQR Uv3KKdnS1eCYqQ7MtHeAFSsim8lkR8LBrH/bPsbiQYij4QHjwneQjRzDwhcrM5w5sgEaqAnBN+Cui Nd/Q52UHWWI7HWh2R3esTgG+YiBwzvgKAVYwX06IG1i3wvuFNJOEhS/iu1oiyYko1Ih0fdwNLttbJ qd8IH7gtJpjL5lZVWfmM5Uc/UzyE61PnMuP2mMSzHUPdbePLoikGFGGdXHzOTlE4WyV8tuc+S3QWo +u0q0fjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA5F0-00000005mjh-314V; Thu, 23 May 2024 10:00:06 +0000 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA5Eu-00000005mfw-49rS for linux-nvme@lists.infradead.org; Thu, 23 May 2024 10:00:05 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DC1E9200A9; Thu, 23 May 2024 09:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716458399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXFkJ8d8gv22e48RVMGd5BeV2r93UQI+UE+HOEciU/8=; b=jETihJhPZuNBUBm+bl5GTdGsP3gYbuAjFoj6zvKCIRVfrPFywsU6mPtuIv7XOZk/0zBpWM c9KGNc6n9LSz/Wm3VrkNF48UKlYoGrsS3deQPeMICG0I22PxmBJI4mruYIS5QPvmmq9avh 98mFI/Pv2kQT3B1KnjeQDrLn/8ORWQE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716458399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXFkJ8d8gv22e48RVMGd5BeV2r93UQI+UE+HOEciU/8=; b=dRm5APPdyJqPhuwlx9EyQcUBltsTxowAJ6LosoLJD512G5fI7dcE6cBptIpDqO0+K9PXgK rUFOKNULFjEkuuCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zCBlYKcT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=EExmEU0j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716458398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXFkJ8d8gv22e48RVMGd5BeV2r93UQI+UE+HOEciU/8=; b=zCBlYKcTlSIIbjr82mL6u04EukOP+y80cc2gYLG94OQqqjP4zAeSvZ2EK/DhJ8JonYq4Zx yR6PH75vbGPfi2jNGs7GShrIUOQZs3pMBhNYmEG9ilg2Lo4tSQdAZghPAUGCRtsVTUb5w1 2blnbySZZoGoD+iUkh6z00E6L7vXkqQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716458398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXFkJ8d8gv22e48RVMGd5BeV2r93UQI+UE+HOEciU/8=; b=EExmEU0jPKQ8sy88YRH6Phn4chVCL/syKyRNdtp++zXeCQyUQ34NDfBwqruICS49zJFHT2 dRUEsBlsuy93JJBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C2FCC13A6C; Thu, 23 May 2024 09:59:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id J9QoL54TT2YaRgAAD6G6ig (envelope-from ); Thu, 23 May 2024 09:59:58 +0000 Message-ID: Date: Thu, 23 May 2024 11:59:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: fix multipath batched completion accounting To: Keith Busch , hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org Cc: axboe@kernel.dk, Keith Busch References: <20240521170537.2029233-1-kbusch@meta.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20240521170537.2029233-1-kbusch@meta.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.42 / 50.00]; BAYES_HAM(-2.92)[99.66%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email] X-Rspamd-Action: no action X-Rspamd-Queue-Id: DC1E9200A9 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240523_030001_216699_C3DCF4A6 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 5/21/24 19:05, Keith Busch wrote: > From: Keith Busch > > Batched completions were missing the io stats accounting and bio trace > events. Move the common code to a helper and call it from the batched > and non-batched functions. > > Fixes: d4d957b53d91ee ("nvme-multipath: support io stats on the mpath device") > Signed-off-by: Keith Busch > --- > drivers/nvme/host/core.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes