From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Jan Hoeppner" <hoeppner@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
"Song Liu" <song@kernel.org>,
dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
"Jack Wang" <jinpu.wang@ionos.com>,
linux-s390@vger.kernel.org, "Richard Weinberger" <richard@nod.at>,
xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
"Mike Snitzer" <snitzer@kernel.org>,
"Josef Bacik" <josef@toxicpanda.com>,
nbd@other.debian.org, linux-block@vger.kernel.org,
"Stefan Haberland" <sth@linux.ibm.com>,
linux-raid@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [dm-devel] [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
Date: Mon, 18 Apr 2022 17:02:13 +0900 [thread overview]
Message-ID: <cd77bfd9-e133-1929-2d61-73822ad95366@opensource.wdc.com> (raw)
In-Reply-To: <20220418045314.360785-10-hch@lst.de>
On 4/18/22 13:53, Christoph Hellwig wrote:
> The nvme driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b9b0fbde97c80..76a9ccd5d064a 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1628,7 +1628,6 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
> BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
> NVME_DSM_MAX_RANGES);
>
> - queue->limits.discard_alignment = 0;
> queue->limits.discard_granularity = size;
>
> /* If discard is already enabled, don't reset queue limits */
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-04-18 8:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 4:53 fix and cleanup discard_alignment handling Christoph Hellwig
2022-04-18 4:53 ` [PATCH 01/11] ubd: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 4:53 ` [PATCH 02/11] nbd: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 03/11] null_blk: " Christoph Hellwig
2022-04-18 8:01 ` [dm-devel] " Damien Le Moal
2022-04-18 21:22 ` Chaitanya Kulkarni
2022-04-18 4:53 ` [PATCH 04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits Christoph Hellwig
2022-04-18 4:53 ` [PATCH 05/11] dm-zoned: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 8:00 ` [dm-devel] " Damien Le Moal
2022-04-18 4:53 ` [PATCH 06/11] raid5: " Christoph Hellwig
2022-04-25 21:08 ` Song Liu
2022-04-18 4:53 ` [PATCH 07/11] dasd: " Christoph Hellwig
2022-05-06 12:56 ` Jan Höppner
2022-04-18 4:53 ` [PATCH 08/11] loop: remove a spurious clear of discard_alignment Christoph Hellwig
2022-04-18 8:04 ` [dm-devel] " Damien Le Moal
2022-04-18 21:21 ` Chaitanya Kulkarni
2022-04-18 4:53 ` [PATCH 09/11] nvme: " Christoph Hellwig
2022-04-18 8:02 ` Damien Le Moal [this message]
2022-04-18 21:23 ` Chaitanya Kulkarni
2022-04-26 14:25 ` Sagi Grimberg
2022-04-18 4:53 ` [PATCH 10/11] rnbd-srv: use bdev_discard_alignment Christoph Hellwig
2022-04-18 8:02 ` [dm-devel] " Damien Le Moal
2022-04-19 4:51 ` Jinpu Wang
2022-04-18 4:53 ` [PATCH 11/11] xen-blkback: " Christoph Hellwig
2022-04-18 8:03 ` [dm-devel] " Damien Le Moal
2022-04-26 4:16 ` fix and cleanup discard_alignment handling Martin K. Petersen
2022-05-02 16:46 ` Christoph Hellwig
2022-05-03 16:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd77bfd9-e133-1929-2d61-73822ad95366@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jinpu.wang@ionos.com \
--cc=johannes@sipsolutions.net \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=sth@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox