From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A673FD8FD8 for ; Thu, 26 Feb 2026 16:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w6qNtiqSBbApIMksjHLOMt2rP0Hvr3Vlgv29CnCWCBg=; b=x7+BkexTK1aQYIOvrzXl/hXbWN gEfqbWVhtGVuTEAWDpTIdGO73R8EvGDcVxPrOhFV3Ilf3hLvxwLQCwTeqGJgrAWbbuxR7Rq27mUHZ DpL8u2binYerbc5bvP6GpUpVT40dQujc9GK2/QNtC7B8AxUF6LLOxfaG6BbPWw7nKnj7c3hkcZe26 3pTcvYX1SzrtnbrBlyoGD835nhtOKugBb9wD0bJROW4QrRdUCsnxW0GeWgBtg9cp6yDdixOVajM4O 9az0qbePe4hScWFjO/VppVtx12qzGpRazyMo6XZX9UaXPgeumt5bJz2Z6yXrXS2S05Xs00M4dI8xm 2zOIFXLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vveea-00000006n3X-32zb; Thu, 26 Feb 2026 16:55:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vveeZ-00000006n2o-18ek for linux-nvme@bombadil.infradead.org; Thu, 26 Feb 2026 16:55:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:In-Reply-To:From:References:Cc:To:Subject:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=w6qNtiqSBbApIMksjHLOMt2rP0Hvr3Vlgv29CnCWCBg=; b=CfmeNSQ4nQhmSehpHpJQNXGKqU hybJ8P05Qx/Bo7+GGMbq0Y8+/iAhAT4eIlVL4Nz87HaOnyydM9Jx/Kr+rfPaqp3jsm1fdva9lnuYd RdFOX5f0RZV/TIcBhux6YwKPusqsyItGzk5a1LbNCFjGpZ8MBx397GRme66COba1Zr3Bv+JQvX77U 0Ke1+VTcGjZq8CYBT5yjwXS6wRYRiEdTY+DitSBF6fL1eQKxclnXRewvVrOSgPFZii+ls/q/rHSZb pzz+PHAmuZm2RRJtPknBH0KCZ3RSziPxz7/i3HXkQMKV/YASauVYP3DVAsKvcM8svu8Jn9Z51JzgJ by8Y+2qA==; Received: from mail-westusazon11010018.outbound.protection.outlook.com ([52.101.85.18] helo=BYAPR05CU005.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vveeU-0000000BYgQ-2Y0G for linux-nvme@lists.infradead.org; Thu, 26 Feb 2026 16:55:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vwRRARjZDgLDBnW8yNdibPoGJNKidxmQaJj0hVDArBBPU9AG2MsRvSFbbZjrxLm3567g1Q2mbW1F7ncIz8c71VLx6uQhSujzPnmFmlN53DOHnQ7+MTJWvxDejjJu74hoFHjn5OVul+f8g0dp1GKAtnpFduXtfsWsL0rzH5XgRD0Zk584XWdIYQmfiQCJUJXhHuMjkF7bkAbW6vM89GUZvvnUthKhyfueuTWBh1SsZ4LmkXYz3WQlEtdHnUZNcYc4ICGTs+5UwyjM/VahL6uHjogsMHSxN+fHsuLaN/xTZTDW3QRtVvltsCSNzACPOsULdiSewDqRue0wJZMlQbpI6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w6qNtiqSBbApIMksjHLOMt2rP0Hvr3Vlgv29CnCWCBg=; b=ej2SJfMfZgVaSqyjZkZTosrjhYHm34psiAOVmdhLAR6c5iuHvMqvwDdxJu75Lf/6+9QrlGHWjgstoRvAY7f7bdAtfU2v1H6ppyczVLYewyJVrBX0zXCYUEISq55co91bU5+H3QVoSWvfzWbxjmGVEW/5nEp/e21RtfibzCtir0WeHP4uTX9jFhGuE7HwlmBE+ZXWFqci+TiqNOPf+LviG2MWZcYq8hPz0/xEoGEEjUmzO1wglrrJez7SXinnbe/UuqbVdHJqyo9dMqlzPhO8c00yvqLoqLSFTRZKwqROKIaxWbYJ4Dk+rfyrmIaN0COYCzqvzmIz+nsilx3RCSwM3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6qNtiqSBbApIMksjHLOMt2rP0Hvr3Vlgv29CnCWCBg=; b=H5ruoMgI1gG60ZrGcnHmXSAUQJ9xSCdNoxXB14UBD6Vu3+9EMXkOaoIFliR6kVemuO7bKXs1LsOZ3jHWXS10UKdnd9qxDwFYhzqlLzfkFl0gST71chX8MWkty0U0/13MLwlau+/7tTb3heGql1smFIGYpV8DRZNqerqLZmlmyI19iIQ+zDiZDO3Kor/gbnNp1DdNpjzDLee7jJKiTA7OcWrjRd2Oe339N+amzvbkw09Fj1ewubYUndZVLTu2YUB2TD9oozvlngr5ZMPMXpjVkSJkp8kH4OV1UDYOuyNwoamcaMFGGXSh6TE7DJWmL9UlNs3crXCrq1w9JWmKgeoFTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12) by MN2PR12MB4357.namprd12.prod.outlook.com (2603:10b6:208:262::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.23; Thu, 26 Feb 2026 16:55:40 +0000 Received: from DS2PR12MB9750.namprd12.prod.outlook.com ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com ([fe80::56a8:d6bf:e24c:b391%5]) with mapi id 15.20.9654.014; Thu, 26 Feb 2026 16:55:40 +0000 Message-ID: Date: Thu, 26 Feb 2026 16:55:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] PCI/ASPM: Override the ASPM and Clock PM states set by BIOS for devicetree platforms To: Manivannan Sadhasivam Cc: Manikanta Maddireddy , Bjorn Helgaas , krishna.chundru@oss.qualcomm.com, manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "David E. Box" , Kai-Heng Feng , "Rafael J. Wysocki" , Heiner Kallweit , Chia-Lin Kao , "linux-tegra@vger.kernel.org" , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org References: <20260122152903.GA1247682@bhelgaas> <5z7c25nkb35prvax6vq6ud7eaeuhzsswbf7fqvmlgys3xftgwb@odocboejrdrv> <7157c68e-97f3-43b0-bfb5-e271a8f2a4b8@nvidia.com> From: Jon Hunter Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0065.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::16) To DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PR12MB9750:EE_|MN2PR12MB4357:EE_ X-MS-Office365-Filtering-Correlation-Id: a6ce66b3-09ee-4c56-fa9c-08de7557df53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024; X-Microsoft-Antispam-Message-Info: m57uNyXM6I5+cUw2Wuubj3Jm0+5lN6yFjC6kJELr2dJkARB8EHyaOBAIwuLwXCxE65hRxQZPLDSRVw1PaQ+5g8Ox1Zr6aeu0rTb3NHplblFt6+eBIZWysKCu69PI9IQoHwyY9ReT5TW8dHr7W7J0JlEur+cFrFAFx0gJ061ceGdBjQAWjyVZJL/rNmJT2dCO4MyRxN6pCUY7bvu6ZA5ReEqe+Wq7HRlJDuGV7PjK2cgwb8c81icHpG2jNk7JmYtNJCjia5Qvd30JZkxZHpIbidHsTgRQs7Pc8NsNN0F5XYOYsSHLPwVSo8wg5/vbXjQj2XBST/93p1QUkFs1EDhYu3CcORphufEzfKUJ7XD1kCo1BINXkj0958VdyOf4bScIfbRfkqynrOsELpjiwKwU7rZFHiW3fbLUVcT8P+ZmNFuf6VFuzl6nfdBYiFAm6P+fnThdg55O+MQ70OlIXIFFmkUDR8y/DabV/McacHPF+n/Q53rOm872EO1r46nDMYvt5ZKqJq/NykNV6I5zKRLadtPrO4IKUs7DHyJQLcoK89RG9QELXJZb/DKTY4WCX8VP921Zd73yQGYnEMl8F7emxTOs56+FLhmh6a/hOUihwkVTqQYi7lPCCPZDX9WETlMuaCppguwmKVfHwj0SX0DXgWkpU3+Nzp1Qjek2yd7pqkbv9q15UnUhmqcK87qvn/KZXSiIwhjq6u1fpdoOpV8IE1MpDuD+O0/kSXJ/ilfMI7M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzk5L3dMcnlMTUYrR1JVS2cybDR5UTh2YUlYMEJzK2xseDU4NSs0VTNCSjRm?= =?utf-8?B?ekpKSDhOVUFvOTVTZlQ2b3Z0Q0NUbnRvUU12TmRES0ZuSWk2dCtkZ3MxR2NK?= =?utf-8?B?RmdlZVFZT3Z6cWZTamdTOVkrNzFrMXV0Y2ZJZUJ1UTN6dFlEeXF2eE1laFFt?= =?utf-8?B?cHRtanA2RVRxNnQ0c2pEeE83cy9vSjZDc1BWenRHRG96OWFQamZpN21naTgy?= =?utf-8?B?c2loSUI1cnRpamRGRTVFVUFJTFVNOGtNZGl4ZFpzemFmZWhLMUxXU3U4NE1C?= =?utf-8?B?MGhYOVhJeEN1bnhuNFhhQ3N5R0hyTXkwZlIvRTJEOEdqTHljVlc0RzRvK1VW?= =?utf-8?B?UWUwbkFobzl0a0lZSDgzUVQyL3NvOURuMnpoRzVtb3Q3d0FxL0hKZEhwdmxJ?= =?utf-8?B?ZkpQbG5oVmYxOFo5Vk43bCtiRVVxQUhLbXU2ZFpjWXBuVW5tZDcxSW1qLzRZ?= =?utf-8?B?bG1KYXpqVHRSWmZ5cXh3UG0vZE5Eb1Q2YUhwM21TZ3ZoS2I4VlFrRDd5UGF5?= =?utf-8?B?UHlvWFNMR2NHckk5cHp1eGJOODQwdUVHeXJhQ2UrNmVvTGRXTU56eWxEdTBj?= =?utf-8?B?NU5UbHhtN1VYWFoyalBvUEg5R2pjelBGL0VzWXNtL1k3SWZ1WDRNa2p4TnNP?= =?utf-8?B?SjFZV1FSa2hRekpSeUdmR25Rb1FFWFFkeEVGTjNIcG5ha3pMMXhXYzZrS1c5?= =?utf-8?B?QTZuS05DQnRiSXhkZW9mVUY1V2hjOWIwZGJxNWJLWHJvY2M2RVNoZ25wSE0y?= =?utf-8?B?b0VTa1hLTmpkM1pUSm5DT0tGVlFqOC92eitUNzc0VjhxODNXVDA5V3ZBWXln?= =?utf-8?B?MWhVQUxQQVdoc2tFeVdlM1lMSlZ3bHJJdWUrUXo3Y3cwa292ajFwWFYvNUVB?= =?utf-8?B?WkpOQk9zWGE1Y0RZakg1ZmtTckVxbno2LzlHMTFVV3dPTUdVZmJuMkl2RVRy?= =?utf-8?B?NHBuRjJkUWZBVUN5VUZKdzhBUzRzUkcrSS9zeGtDZTV4UVdmUG9YZEYwNEhX?= =?utf-8?B?R3loWEgvYXBlUFJ6ZlJ0azhPS084ZXp4Uk9jbUJ6L0N5d2lvR1JwYVpKZ1Fu?= =?utf-8?B?TThXRy84NHNPT1AvOUhGZjZkWWtrckY3NDgxM3ZCbUtRRVAzQWhSR2l3c3RB?= =?utf-8?B?S2FlTWdUUTNCcEN1RE1ZVmpZVGI2aXNqNjhRaDNiRWR2bjE3a3liWjRTbk5R?= =?utf-8?B?Z0NNRWxlWk5MZEJPeU5PTjE3ZG8wSGZSTEhuZnNLVHo3a04reVBQZW5JQkFU?= =?utf-8?B?dFVSWGhYUmZZSG8rOFFNOWJBckhPQjdLWkdGZEJyZXRSdHd5d2xmVmRoRU1n?= =?utf-8?B?eFM5MCtwMm4yMUlWeWtKQjYwMzhjMmkxR1Jac0xDc3Q0Y0NON3I4c0F1RVFF?= =?utf-8?B?YzJLTlBzNGJXbFBPWWFaUytBMGxscTJXSHpaYlBYVTN6L0RZNDh1VVZTUjg1?= =?utf-8?B?eG55SFJyNzZFeVZPZHNrYllGUDljYVZYdEt4N2JHREhCNVZ0aEdwWkRlRkdz?= =?utf-8?B?N3ljdUlTbjUzUkp6R2RoY3l2VThmazFXR25KUURSWnFFY3crbmdhbEZ6UWRI?= =?utf-8?B?MXVzbkh4ZVV0cDdyQnp4OFBIdlZZNXhpZHpxRDIyOEptNnhvblhjU3MwQUVE?= =?utf-8?B?WnE5VW1kOHd6bHN1V2thSkE5SXdhaWwxZ1p1VnVFTjF4UldaM0JyV1BWN0k5?= =?utf-8?B?QUZHMG5Xd3YyRStPWC9xR0RhVm55YXBUQjN5cy8vLzJJdW1FVW1wVWljZkU1?= =?utf-8?B?RmNPeUxDNkttMzJ0WDB2Qnh5VU1wVmY4QlFCdTZ2N0E0dExjOWhHS2crM2do?= =?utf-8?B?cDFFU2l5eUE2VExCdldMNE1mVHJ6elhTUnR4YjFiSnlRTjhyakxYYW5kZEdx?= =?utf-8?B?K3FGMXZNZTZ3TU52bTB6QnI5b1BWUVhUdkZQQkxMVmR5cko4T1hqMGErRXNL?= =?utf-8?B?RW45QmJ6NlFRSDFVeThxS3gvY1JQWTZKeTNUbU9kR0p0MUc1VzBIOUxRYitp?= =?utf-8?B?VDZMRVVnYW5NcENDbjRwS0l4R3M4SkI0TUxTV1FhQUV1Q3FHKzU5NzV3NVNB?= =?utf-8?B?RTlqZ0dUaDloVTVMQmw1TUF6ZTFqMVNnOWYwRjAxRXVlaUFWNFNlRElmTE1V?= =?utf-8?B?ZDQwY0FnenJicGpleU45dzcxL3V0SmF5QVpFOUpjZHgyeDJUUVd1aS9YcFNU?= =?utf-8?B?L2RWOTV4dmg3c0ZmallTU2U1NFJGRFpNbkFxdWNleUN2TEk5WGRmVS9CWE1B?= =?utf-8?B?djJVQVpsbTlXNXo4OWZjQVFnMTNtRUtuVFZmZUpyK2tHWWZ1T2ZyTnJmQmlv?= =?utf-8?B?QnhKMC9obDdDT2VrcGFtZHYzTm5TQ3JxSEc4a2JocHhWekVyZm1qQT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6ce66b3-09ee-4c56-fa9c-08de7557df53 X-MS-Exchange-CrossTenant-AuthSource: DS2PR12MB9750.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 16:55:40.3881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QNTpTzBCj+uYZyFDayNfe+WKUIGXAZ5dkcW/URftDPIZ5ERX6M0W+eiruTfedGBjlFx2PlGNCVb0B4Xi3RS7lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4357 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260226_165550_759643_E0C2A9BF X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 26/02/2026 11:08, Manivannan Sadhasivam wrote: ... > Since we know that ASPM is the issue on your platform and the failure also > confirms that ASPM was never enabled before, I'd suggest disabling ASPM for the > Root Port as a workaround: > > ``` > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 06571d806ab3..f504b4ffbcb6 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -2499,6 +2499,13 @@ module_platform_driver(tegra_pcie_dw_driver); > > MODULE_DEVICE_TABLE(of, tegra_pcie_dw_of_match); > > +static void tegra_pcie_quirk_disable_aspm(struct pci_dev *dev) > +{ > + pcie_aspm_remove_cap(dev, PCI_EXP_LNKCAP_ASPM_L1 | > + PCI_EXP_LNKCAP_ASPM_L0S); > +} > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, tegra_pcie_quirk_disable_aspm); > + > MODULE_AUTHOR("Vidya Sagar "); > MODULE_DESCRIPTION("NVIDIA PCIe host controller driver"); > MODULE_LICENSE("GPL v2"); > ``` > > You can use specific Root Port IDs or PCI_ANY_ID depending on the impact. We can > also work on fixing the actual issue parallelly. Thanks. By default we are building the PCIe driver for Tegra as a module and so I am not sure we can use DECLARE_PCI_FIXUP_EARLY() right? I was just thinking that in pcie_aspm_override_default_link_state() we just need a callback to specify the default ASPM override state? Cheers Jon -- nvpublic