linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: luto@kernel.org (Andy Lutomirski)
Subject: [PATCH 0/3] nvme power saving
Date: Mon, 29 Aug 2016 02:25:43 -0700	[thread overview]
Message-ID: <cover.1472462539.git.luto@kernel.org> (raw)

Hi all-

Here's v1 of the APST patch set.  The biggest bikesheddable thing (I
think) is the scaling factor.  I currently have it hardcoded so that
we wait 50x the total latency before entering a power saving state.
On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry
latency, 5ms exit latency) after 275ms and state 4 (5mW, 2ms entry
latency, 22ms exit latency) after 1200ms.  I have the default max
latency set to 25ms.

FWIW, in practice, the latency this introduces seems to be well
under 22ms, but my benchmark is a bit silly and I might have
measured it wrong.  I certainly haven't observed a slowdown just
using my laptop.

Andy Lutomirski (3):
  nvme/scsi: Remove power management support
  nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
  nvme: Enable autonomous power state transitions

 drivers/nvme/host/core.c | 199 +++++++++++++++++++++++++++++++++++++++++++++--
 drivers/nvme/host/nvme.h |  10 ++-
 drivers/nvme/host/scsi.c |  80 ++-----------------
 include/linux/nvme.h     |   6 ++
 4 files changed, 211 insertions(+), 84 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-08-29  9:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  9:25 Andy Lutomirski [this message]
2016-08-29  9:25 ` [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-08-29  9:25 ` [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-08-29 16:27   ` Keith Busch
2016-08-29 23:20     ` Andy Lutomirski
2016-08-30  6:36       ` Christoph Hellwig
2016-08-30 16:00         ` Andy Lutomirski
2016-08-29  9:25 ` [PATCH 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-08-29 15:07   ` J Freyensee
2016-08-29 23:16     ` Andy Lutomirski
2016-08-30 20:21       ` Andy Lutomirski
2016-09-02 18:11         ` J Freyensee
2016-09-02 18:50           ` Andy Lutomirski
2016-08-29 16:45   ` Keith Busch
2016-08-29 23:16     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1472462539.git.luto@kernel.org \
    --to=luto@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).