From: luto@kernel.org (Andy Lutomirski)
Subject: [PATCH v3 0/3] nvme power saving
Date: Thu, 15 Sep 2016 22:24:18 -0700 [thread overview]
Message-ID: <cover.1474002926.git.luto@kernel.org> (raw)
Hi all-
Here's v3 of the APST patch set. The biggest bikesheddable thing (I
think) is the scaling factor. I currently have it hardcoded so that
we wait 50x the total latency before entering a power saving state.
On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry
latency, 5ms exit latency) after 275ms and state 4 (5mW, 2ms entry
latency, 22ms exit latency) after 1200ms. I have the default max
latency set to 25ms.
FWIW, in practice, the latency this introduces seems to be well
under 22ms, but my benchmark is a bit silly and I might have
measured it wrong. I certainly haven't observed a slowdown just
using my laptop.
This time around, I changed the names of parameters after Jay
Frayensee got confused by the first try. Now they are:
- ps_max_latency_us in sysfs: actually controls it.
- nvme_core.default_ps_max_latency_us: sets the default.
Yeah, they're mouthfuls, but they should be clearer now.
Changes from v2:
- Rename the parameters.
Changes from v1:
- Get rid of feature buffer alignment warnings.
- Change the error message if NPSS is bogus.
- Rename apst_max_latency_ns to apst_max_latency_us because module params
don't like u64 or unsigned long long and I wanted to make it fit more
comfortably in a ulong module param. (And the nanoseconds were useless.)
- Add a module parameter for the default max latency.
Andy Lutomirski (3):
nvme/scsi: Remove power management support
nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
nvme: Enable autonomous power state transitions
drivers/nvme/host/core.c | 184 ++++++++++++++++++++++++++++++++++++++++++++---
drivers/nvme/host/nvme.h | 10 ++-
drivers/nvme/host/scsi.c | 80 ++-------------------
include/linux/nvme.h | 6 ++
4 files changed, 196 insertions(+), 84 deletions(-)
--
2.7.4
next reply other threads:[~2016-09-16 5:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 5:24 Andy Lutomirski [this message]
2016-09-16 5:24 ` [PATCH v3 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 8:33 ` Christoph Hellwig
2016-09-16 14:33 ` Keith Busch
2016-09-16 14:25 ` Christoph Hellwig
2016-09-19 7:59 ` Johannes Thumshirn
2016-09-16 23:33 ` J Freyensee
2016-09-16 5:24 ` [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 8:41 ` Christoph Hellwig
2016-09-16 15:13 ` Andy Lutomirski
2016-09-16 15:34 ` Jens Axboe
2016-09-16 5:24 ` [PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-16 8:42 ` Christoph Hellwig
2016-09-16 15:14 ` Andy Lutomirski
2016-09-16 16:51 ` Christoph Hellwig
2016-09-16 15:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1474002926.git.luto@kernel.org \
--to=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).