From: luto@kernel.org (Andy Lutomirski)
Subject: [PATCH v4 0/2] [PATCH v4 0/2] nvme: APST support
Date: Tue, 7 Feb 2017 10:08:43 -0800 [thread overview]
Message-ID: <cover.1486490885.git.luto@kernel.org> (raw)
As far as I can tell, APST works fine on every NVMe device I'm aware
of with the single exception of a particular Samsung device. This
series enables APST by default but quirks it off on the offending
Samsung device. Some Samsung engineers are taking a look, and,
depending on what they find, we may be able to change the quirk to
work around the bug rather than disabling APST outright.
I think it would be nice to queue this up for 4.11.
Changes from v3:
- Initialize APST in nvme_init_identify() (hch)
Changes from v2:
- Remove a stray newline.
- Use switch when translating pm_qos args to latency (Christoph)
- I did *not* change the initialization sequence. If we want to do
that, can it be a followup patch?
Changes from v1:
- Fix a totally wrong comment in the quirk code (me)
- Add a comment about not redetecting quirks after reset (Keith)
- Rearrange the series to avoid bisection problems (Jens)
Once fully applied, v1 and v2 only differ in their comments.
Changes from before:
- Rebased to linux-block/for-next.
- I added a quirk for the known-bad Samsung device.
- It's fully integrated with dev_pm_qos.
- I now program APST after all the queues are set up, which seems safer.
(This didn't fix the Samsung problem, though.)
Andy Lutomirski (2):
nvme: Add a quirk mechanism that uses identify_ctrl
nvme: Enable autonomous power state transitions
drivers/nvme/host/core.c | 218 +++++++++++++++++++++++++++++++++++++++++++++++
drivers/nvme/host/nvme.h | 12 +++
include/linux/nvme.h | 6 ++
3 files changed, 236 insertions(+)
--
2.9.3
next reply other threads:[~2017-02-07 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 18:08 Andy Lutomirski [this message]
2017-02-07 18:08 ` [PATCH v4 1/2] nvme: Add a quirk mechanism that uses identify_ctrl Andy Lutomirski
2017-02-07 18:08 ` [PATCH v4 2/2] nvme: Enable autonomous power state transitions Andy Lutomirski
2017-02-07 19:38 ` Christoph Hellwig
2017-02-15 10:00 ` [PATCH v4 0/2] [PATCH v4 0/2] nvme: APST support Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1486490885.git.luto@kernel.org \
--to=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox