From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: Fix missing error code in nvme_configure_directives()
Date: Thu, 9 Sep 2021 16:20:42 +0000 [thread overview]
Message-ID: <d07f0dbd-968c-df42-ca1f-1def57bdd2ef@nvidia.com> (raw)
In-Reply-To: <1631181021-108687-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 9/9/21 2:50 AM, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
>
> Eliminate the follow smatch warning:
>
> drivers/nvme/host/core.c:786 nvme_configure_directives() warn: missing
> error code 'ret'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: f5d118406247 ("nvme: add support for streams and directives")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-09 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 9:50 [PATCH] nvme: Fix missing error code in nvme_configure_directives() Jiapeng Chong
2021-09-09 14:07 ` Christoph Hellwig
2021-09-09 14:47 ` Keith Busch
2021-09-09 14:50 ` Christoph Hellwig
2021-09-09 16:25 ` Chaitanya Kulkarni
2021-09-09 16:20 ` Chaitanya Kulkarni [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-15 3:36 Jiapeng Chong
2022-02-15 3:55 ` Keith Busch
2022-02-15 6:22 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07f0dbd-968c-df42-ca1f-1def57bdd2ef@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox