From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B559D6EBFF for ; Fri, 29 Nov 2024 11:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E6NbRZTiMaRHXP3i5mnvV0WgISU2CGtziKf9MHF1EoQ=; b=CLzQ8CrqLaT2DiWNGaN7Ui1bI0 fmrq4jNwW2BafnHVvDVYdYj50BHzl1zcmhpNXZ22gY3k+anx+jHTmvbx20tn52nx2wk4sy4nHseA+ kxq9Ztxu64z5X9AnTwswprf5GZl0Xfmv7qwWUD97AVSkR5/pWYD9oNuFKwW1N9TJy+aisZDlJF7AE IMFhwtGNMxoJe+3RLRGjnHQV0q+aYBTjdJxYxxDrjCwsJvzY210rg+ItxgGxQnceaeJsSClKTk4dn 0g7AwOnSMlm74arvNKA/n8SlnZ626h16WWaxolivcS94VN4Zl05WmCF5XIJb0bhKfXd6ai35MQA3r clRnB29Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGz1u-0000000HWbG-43c1; Fri, 29 Nov 2024 11:19:22 +0000 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGz1U-0000000HWWR-1kZT for linux-nvme@lists.infradead.org; Fri, 29 Nov 2024 11:18:57 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1F751F391; Fri, 29 Nov 2024 11:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732879135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6NbRZTiMaRHXP3i5mnvV0WgISU2CGtziKf9MHF1EoQ=; b=pBLkYiO/0MtDqCFO5eX9uDoh8UeLUsI0Xq81UIEc4YEnmpSBGN6dN35gBNsAfx58wmYKcI eDSvJUPQmjm4ot5UcpBa1fOSEeq+5JxAnEyfozUICjnHFqhEQUHGAlRSTtQ1VJIGl+h4Cn Os3YGBJ3qHtrLaulCFFogQ7MUp6Eqaw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732879135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6NbRZTiMaRHXP3i5mnvV0WgISU2CGtziKf9MHF1EoQ=; b=PBKpaYy1NkeZX2Ib8THmNz0sk/73By0eb7FpBhQEhzTSpsX93M4ry5No+aZYkqphPbhuPL pw1hjRSlcTo6ksAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rn3hSR8l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VfAawE1X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732879134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6NbRZTiMaRHXP3i5mnvV0WgISU2CGtziKf9MHF1EoQ=; b=rn3hSR8l1pQpDRTgX2qZjbS0USlnpAxGci/67kOdr09eM8qyD8FR8CBNcyq3N6xf99rRks tpLmb9sBchqJrJLwC/xwTwal9Df2obyQClZvhsfCPgNllhh8aUknikp7dQbesKohEPdz1J vgpMhFmOHcrX8x0bQH7XrkUYrPCgahY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732879134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6NbRZTiMaRHXP3i5mnvV0WgISU2CGtziKf9MHF1EoQ=; b=VfAawE1X91EPKw6EOaA/vi3sAd1q1YOHFcS6e3iq2E+ofWEeO1iwpygXBc0xyvnpqBMno3 a8SCkDr2jdsMvoAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0C4F139AA; Fri, 29 Nov 2024 11:18:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id p+CaJh6jSWfHdAAAD6G6ig (envelope-from ); Fri, 29 Nov 2024 11:18:54 +0000 Message-ID: Date: Fri, 29 Nov 2024 12:18:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] nvme-tcp: no need to quiesec admin_q in nvme_tcp_teardown_io_queues() To: "brookxu.cn" , kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C1F751F391 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com,kernel.org,kernel.dk,lst.de,grimberg.me]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241129_031856_602191_70A2C343 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 11/23/24 14:37, brookxu.cn wrote: > From: "Chunguang.xu" > > As we quiesec admin_q in nvme_tcp_teardown_admin_queue(), so we should no > need to quiesec it in nvme_tcp_reaardown_io_queues(), make things simple. > quiesce ... > Signed-off-by: Chunguang.xu > --- > drivers/nvme/host/tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c > index 3e416af2659f..47d8f10b1f75 100644 > --- a/drivers/nvme/host/tcp.c > +++ b/drivers/nvme/host/tcp.c > @@ -2178,7 +2178,6 @@ static void nvme_tcp_teardown_io_queues(struct nvme_ctrl *ctrl, > { > if (ctrl->queue_count <= 1) > return; > - nvme_quiesce_admin_queue(ctrl); > nvme_quiesce_io_queues(ctrl); > nvme_sync_io_queues(ctrl); > nvme_tcp_stop_io_queues(ctrl); Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich