From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A365C433E0 for ; Tue, 16 Mar 2021 06:29:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9798E65139 for ; Tue, 16 Mar 2021 06:29:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9798E65139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EraPrvFhu5W48FmcUdNF/zy5WfxPQJbpZnblUGQpVTA=; b=VqMTYZosam6mGUCXSbzOlU0Sf 1lNMSsUCFBFZi7Cxw4SNiY93l3pDl6vqd9kwQCSSF33Ai4xMf8mW0kZVWdeX2n+cbKqF4Uy/GFuXo g7g1jFLBxEzyHDj7qO4jE4fWGv5ik82U/NkkaW1SDz0a29ACq209oykyUzrx37IN1I/HM9SyEWLCk QWN9B0jcIxfqm44I2BxQEU4RtVnTT0/lhZQKc4dajZEp0xX6OG/9ueCYsg5oyTvBM39TFQQ0Nnwk4 oz5182vyFgfoy4R+TUG6qVssUexX3QFPHv400+MXoUl57mKIz9ix2mCp8TamlHybYacPQNrbZUGjB TEKOV+Rog==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lM3DC-00HWqo-FL; Tue, 16 Mar 2021 06:29:50 +0000 Received: from mail-pf1-f172.google.com ([209.85.210.172]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lM3D7-00HWpj-83 for linux-nvme@lists.infradead.org; Tue, 16 Mar 2021 06:29:47 +0000 Received: by mail-pf1-f172.google.com with SMTP id a188so8129567pfb.4 for ; Mon, 15 Mar 2021 23:29:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1g6yOPMw6+uZkbHHkE8duN+GenWroMFCqGvWbZfdqA8=; b=aGZAr6MzcKqojKMAb7gJq19q+vUMVbGKcLRa086N7+m7S5XAGayS1c19PfJtkIQB8V 7DiiE7dvLuOgbaleEt835vq17nzEnEB1tlaMfJDIX+l3k80T4hxuy/9wwLuH/fvXycan IOk/Kv1+2d2eLENtYjKITYxttceEK1gSBjM/LR6TzyRKFitPZox9bAnOjp5hX2l+WQm7 YmazqnBBVm7ZBuJ/xKZN7n09+gJMolsTKDDpf/JB7hnb8o3YyMI2wRckWRFF9+z9xkek ndlvVMjFivYgW4ZlVM6A5SJAGWumq6EZ5Numb+zImM57gyLUVymTTbG6Y7f/rQVdbDDn FC+g== X-Gm-Message-State: AOAM5324YSQRsbBTS0ivx7iA3E5U7iD9FqYQey912ZFTgwYfbEQMafk6 pIJm6xJCR+EjWQ9V1GEgDiE= X-Google-Smtp-Source: ABdhPJzTTBxKY0+Vd6VdxfD/5O3lANh5GyFzZAL8DQF3Ii/c4Y/0VEsIeApe6InEcUl2p8CD7iZRxw== X-Received: by 2002:aa7:8ad5:0:b029:1df:5a5a:80e1 with SMTP id b21-20020aa78ad50000b02901df5a5a80e1mr13626198pfd.52.1615876183935; Mon, 15 Mar 2021 23:29:43 -0700 (PDT) Received: from ?IPv6:2601:647:4802:9070:52e4:89ef:d916:a3a6? ([2601:647:4802:9070:52e4:89ef:d916:a3a6]) by smtp.gmail.com with ESMTPSA id y15sm17234428pgi.31.2021.03.15.23.29.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 23:29:43 -0700 (PDT) Subject: Re: [PATCH] nvmet-tcp: Fix receive data digest calculation for multiple h2cdata PDUs To: "Grupi, Elad" , "linux-nvme@lists.infradead.org" , Christoph Hellwig , Keith Busch , Chaitanya Kulkarni References: <20210203230001.18797-1-sagi@grimberg.me> From: Sagi Grimberg Message-ID: Date: Mon, 15 Mar 2021 23:29:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_062945_772997_8F00FAB6 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > Hi Sagi, Hey Elad, > Can you please explain why you avoid calling nvmet_tcp_unmap_pdu_iovec on data_digest PDU? > I don't recall any other case that unmap is being called on good path. You are correct. We need to either add unmap in the data_digest path here or when completing the data digest reception.. Probably better here. Care to send a patch or should I? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme