From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Leon Romanovsky <leon@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA
Date: Thu, 13 Nov 2025 13:40:50 -0700 [thread overview]
Message-ID: <d1641814-5ef8-4ccd-8a41-42bf99a61d0d@kernel.dk> (raw)
In-Reply-To: <aRY28IRvBFmTW6cz@kbusch-mbp>
On 11/13/25 12:52 PM, Keith Busch wrote:
> On Thu, Nov 13, 2025 at 10:45:53AM -0700, Jens Axboe wrote:
>> I took a look, and what happens here is that iter.p2pdma.map is 0 as it
>> never got set to anything. That is the same as PCI_P2PDMA_MAP_UNKNOWN,
>> and hence we just end up in a BLK_STS_RESOURCE. First of all, returning
>> BLK_STS_RESOURCE for that seems... highly suspicious. That should surely
>> be a fatal error. And secondly, this just further backs up that there's
>> ZERO testing done on this patchset at all. WTF?
>>
>> FWIW, the below makes it boot just fine, as expected, as a default zero
>> filled iter then matches the UNKNOWN case.
>
> I think this must mean you don't have CONFIG_PCI_P2PDMA enabled. The
Right, like most normal people :-)
> state is never set in that case, but I think it should have been.
If you want the patchset to boot, yes it should have been...
--
Jens Axboe
next prev parent reply other threads:[~2025-11-13 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 19:48 [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA Leon Romanovsky
2025-11-12 19:48 ` [PATCH v4 1/2] nvme-pci: migrate to dma_map_phys instead of map_page Leon Romanovsky
2025-11-12 23:57 ` Chaitanya Kulkarni
2025-11-12 19:48 ` [PATCH v4 2/2] block-dma: properly take MMIO path Leon Romanovsky
2025-11-12 20:00 ` Keith Busch
2025-11-12 23:57 ` Chaitanya Kulkarni
2025-11-13 16:39 ` [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA Jens Axboe
2025-11-13 17:12 ` Jens Axboe
2025-11-13 17:45 ` Jens Axboe
2025-11-13 19:50 ` Leon Romanovsky
2025-11-13 20:03 ` Keith Busch
2025-11-13 20:13 ` Leon Romanovsky
2025-11-13 20:40 ` Leon Romanovsky
2025-11-13 20:43 ` Jens Axboe
2025-11-14 8:13 ` Leon Romanovsky
2025-11-13 19:52 ` Keith Busch
2025-11-13 20:40 ` Jens Axboe [this message]
2025-11-14 8:16 ` Leon Romanovsky
2025-11-14 12:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1641814-5ef8-4ccd-8a41-42bf99a61d0d@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox