From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v1] nvmet-rdma: don't forget to delete a queue from the list of connection failed
Date: Sun, 6 Nov 2016 23:33:44 +0200 [thread overview]
Message-ID: <d3557d0b-c696-a380-d9a2-3a21b9744c77@grimberg.me> (raw)
In-Reply-To: <20161106192944.GA18397@lst.de>
>> In case we accepted a queue connection and it failed, we might not
>> remove the queue from the list until we unload and clean it up.
>> We should delete it from the queue list on the relevant handler.
>
> I think for this to work we'll also need to initialize
> ->queue_list when allocating the queue.
Not really because we'll only manipulate the queue_list if we accept
which means that it's in the list, nvmet_rdma_queue_connect() failures
won't ever see nvmet_rdma_queue_connect_fail(). But I can add it for
good measures...
prev parent reply other threads:[~2016-11-06 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 17:30 [PATCH v1] nvmet-rdma: don't forget to delete a queue from the list of connection failed Sagi Grimberg
2016-11-06 19:29 ` Christoph Hellwig
2016-11-06 21:33 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3557d0b-c696-a380-d9a2-3a21b9744c77@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).