From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
"dwagner@suse.de" <dwagner@suse.de>,
"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Israel Rukshin <israelr@nvidia.com>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 4/4] nvmet: add --qid-max support for subsystem creation and setup
Date: Tue, 30 Sep 2025 01:43:43 +0000 [thread overview]
Message-ID: <d394dbe3-6b4d-428c-a5af-1e34b59cacf2@nvidia.com> (raw)
In-Reply-To: <20250928115125.38383-5-mgurtovoy@nvidia.com>
On 9/28/25 04:51, Max Gurtovoy wrote:
> Introduce support for the --qid-max argument to both
> _create_nvmet_subsystem and _nvmet_target_setup functions, allowing
> configuration of the maximum queue ID through the "attr_qid_max" sysfs
> attribute when available. This enables more flexible queue management
> for NVMe subsystems.
>
> Additionally, update test 048 to set qid_max via the new --qid-max
> workflow. This will follow the new logic added to the NVMe target
> driver, which forbid changing the attr_qid_max for a discovered
> subsystem.
>
> Also increase the sleep durations to adjust real RDMA HW devices.
>
> Signed-off-by: Max Gurtovoy<mgurtovoy@nvidia.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-09-30 1:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 11:51 [PATCH 0/4] NVMe: add support for mlx5 RDMA HW and test enhancements Max Gurtovoy
2025-09-28 11:51 ` [PATCH 1/4] nvme/061: increase nvmf state wait timeout to 10s Max Gurtovoy
2025-09-30 1:44 ` Chaitanya Kulkarni
2025-09-28 11:51 ` [PATCH 2/4] nvme: add support for mlx5 RDMA devices Max Gurtovoy
2025-09-30 1:44 ` Chaitanya Kulkarni
2025-09-30 3:38 ` Shinichiro Kawasaki
2025-09-28 11:51 ` [PATCH 3/4] nvme/002: extend test to support TCP and RDMA transports Max Gurtovoy
2025-09-30 1:43 ` Chaitanya Kulkarni
2025-09-28 11:51 ` [PATCH 4/4] nvmet: add --qid-max support for subsystem creation and setup Max Gurtovoy
2025-09-30 1:43 ` Chaitanya Kulkarni [this message]
2025-09-30 3:41 ` Shinichiro Kawasaki
2025-09-30 3:46 ` [PATCH 0/4] NVMe: add support for mlx5 RDMA HW and test enhancements Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d394dbe3-6b4d-428c-a5af-1e34b59cacf2@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox