From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH] nvme: zns: limit max_zone_append by max_segments
Date: Mon, 31 Jul 2023 23:33:02 +0900 [thread overview]
Message-ID: <d3d9e1c5-e090-fe65-7d80-850f0d0d284d@kernel.org> (raw)
In-Reply-To: <ZMfEkFBT7D7fizuL@infradead.org>
On 7/31/23 23:26, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 11:12:43PM +0900, Damien Le Moal wrote:
>> max zone append sectors limit indicates the maximum size of a zone append BIO
>> that can be built without ever needing splitting.
>>
>> So if we fix the zns limit, zonefs does not really need a fix, eventhough the
>> code would be a little weird as-is.
>
> You still need to fix splitting due to I/O layout and not just size.
>
> E.g. if your do a writev() with two non-page aligned buffers (you'll
> probably need a arm64 or power box to trigger it), you need to split
> the bio even if it trivially fits into the size limit. Similar for
> things like max_segment_size.
Good point. So fix needed.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-07-31 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 11:46 [PATCH] nvme: zns: limit max_zone_append by max_segments Shin'ichiro Kawasaki
2023-07-31 12:03 ` Damien Le Moal
2023-07-31 13:51 ` Christoph Hellwig
2023-07-31 14:01 ` Damien Le Moal
2023-07-31 14:06 ` Christoph Hellwig
2023-07-31 14:12 ` Damien Le Moal
2023-07-31 14:26 ` Christoph Hellwig
2023-07-31 14:33 ` Damien Le Moal [this message]
2023-07-31 13:46 ` Christoph Hellwig
2023-07-31 14:02 ` Damien Le Moal
2023-07-31 14:05 ` Christoph Hellwig
2023-07-31 14:07 ` Damien Le Moal
2023-07-31 14:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d9e1c5-e090-fe65-7d80-850f0d0d284d@kernel.org \
--to=dlemoal@kernel.org \
--cc=hch@infradead.org \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox