From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Hannes Reinecke <hare@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCHv4 0/7] nvmet: debugfs support
Date: Mon, 8 Apr 2024 18:29:10 +0000 [thread overview]
Message-ID: <d434d186-bfa1-4b44-a9aa-e268b2d41d75@nvidia.com> (raw)
In-Reply-To: <20240326120342.105740-1-hare@kernel.org>
On 3/26/24 05:03, Hannes Reinecke wrote:
> Hi all,
>
> taking up the original patchset for nvmet debugfs
> I've improved upon that submission by modifying
> the layout:
>
> /dev/kernel/debug/nvmet
> <subsysnqn>
> ctrl<cntlid>
> port
> state
> hostnqn
> kato
> host_traddr
>
> The 'state' attribute is the value of the
> CSTS register; one can trigger a controller reset
> by writing 'fatal' into it (to set CSTS.CFS).
>
> As usual, comments and reviews are welcome.
>
>
apart from few nits commented patch-series looks good to me.
Since it does touch all the transport and writes the controller
state transport independent blktest would be very useful to trigger
nvmet_fatal_error_handler() while I/O traffic is running from host ?
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-04-08 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 12:03 [PATCHv4 0/7] nvmet: debugfs support Hannes Reinecke
2024-03-26 12:03 ` [PATCH 1/7] nvmet: add " Hannes Reinecke
2024-04-08 18:20 ` Chaitanya Kulkarni
2024-03-26 12:03 ` [PATCH 2/7] nvmet: add 'host_traddr' callback for debugfs Hannes Reinecke
2024-04-08 18:25 ` Chaitanya Kulkarni
2024-03-26 12:03 ` [PATCH 3/7] nvmet-tcp: implement host_traddr() Hannes Reinecke
2024-03-26 12:03 ` [PATCH 4/7] nvmet-rdma: " Hannes Reinecke
2024-03-26 12:03 ` [PATCH 5/7] nvmet-fc: " Hannes Reinecke
2024-03-26 12:03 ` [PATCH 6/7] nvme-fcloop: implement 'host_traddr' Hannes Reinecke
2024-03-26 12:03 ` [PATCH 7/7] lpfc_nvmet: " Hannes Reinecke
2024-03-26 12:28 ` [PATCHv4 0/7] nvmet: debugfs support Sagi Grimberg
2024-03-26 13:33 ` Daniel Wagner
2024-04-08 16:07 ` Daniel Wagner
2024-04-08 16:35 ` Chaitanya Kulkarni
2024-04-08 18:59 ` Sagi Grimberg
2024-04-08 18:29 ` Chaitanya Kulkarni [this message]
2024-04-08 18:40 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d434d186-bfa1-4b44-a9aa-e268b2d41d75@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox