[PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[Jim.Lin]

SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
"disable write zeroes" can fix this issue and Sk Hynix has been verified.

Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 507bc149046d..f27202680741 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
 		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
+		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x15b7, 0x2001),   /*  Sandisk Skyhawk */
 		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
-- 
2.25.1

RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[Jim Lin 林志融]

Hi Keith Busch

Thanks for your reply.
Changelog updated

Hi David, Hardaway

Please help to check this issue. Thanks.

Thx
BRs
Jim

--------------------------------------------------------------------------------------------------------------------------------------------------------
On Thu, Nov 23, 2023 at 06:06:42PM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than
> 20 mins to switch to developer mode "disable wrtie zero" can fix this issue and Sk Hynix has been verified.
>
> Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>

For the changelog, let's abbreviate the subject to something like:

  "nvme-pci: disable write zeroes for SK Hynix BC901"

> @@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
>               .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>       { PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
>               .driver_data = NVME_QUIRK_BOGUS_NID, },
> +     { PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
> +             .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },

Could we get an "Ack" from the vendor?
------------------------------------------------------------------------------------------------------------------------------------------------------------

-----Original Message-----
From: Jim.Lin <jim.chihjung.lin@gmail.com>
Sent: Tuesday, November 28, 2023 10:58 AM
To: kbusch@kernel.org
Cc: axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; Jim Lin 林志融 <jim.lin@siliconmotion.com>; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; hardaway.tseng@sk.com
Subject: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Please note that this email was sent from outside of SMI.

SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode "disable write zeroes" can fix this issue and Sk Hynix has been verified.

Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 507bc149046d..f27202680741 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
                .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
                .driver_data = NVME_QUIRK_BOGUS_NID, },
+       { PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
+               .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x15b7, 0x2001),   /*  Sandisk Skyhawk */
                .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
--
2.25.1

********************************************************************************
CONFIDENTIALITY AND PROPRIETARY NOTICE: ALL RIGHTS RESERVED.
The information in this message (and any attachments) may contain confidential or proprietary information of the sender, her/his representing company, and its affiliated companies, and is private, privileged and confidential. It is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended and/or designated recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, saving, forwarding or copying of this message (including its attachments) is strictly prohibited. If you have received this email communication in error, please notify the sender immediately and delete this communication entirely and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies from your computer or any device) to avoid any legal problems. Thank you for your cooperation.
********************************************************************************
機密性及專有性警語：版權所有。
此電子郵件及其所有附件(如有之)所含之資訊可能含有寄件者及其所代表公司和其關係企業的機密資訊。除本電子郵件傳送之指定及/或特定對象，其他人非經寄件者許可不得揭露、複製、散佈本郵件及其所有附件。若您非此郵件被指定及/或特定的收件者，或誤收，或在任何原因未經授權的情形下收到本郵件，請勿揭曉本郵件內容予任何人，並即通知原寄件者，亦請自您的電腦完全刪除此信件和任何已列印之文件，以免徒增不必要之法律困擾。謝謝您的合作。

RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[hardaway.tseng]

Hi Keith, Jim and team,

Thanks for efforts!

This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Thank you so much!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan
Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Jim Lin 林志融 <jim.lin@siliconmotion.com> 
Sent: Tuesday, November 28, 2023 11:03 AM
To: Jim.Lin <jim.chihjung.lin@gmail.com>; kbusch@kernel.org
Cc: axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; Hardaway (Shih Hung) Tseng SKHYT <hardaway.tseng@sk.com>
Subject: RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Hi Keith Busch

Thanks for your reply.
Changelog updated

Hi David, Hardaway

Please help to check this issue. Thanks.

Thx
BRs
Jim

--------------------------------------------------------------------------------------------------------------------------------------------------------
On Thu, Nov 23, 2023 at 06:06:42PM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than
> 20 mins to switch to developer mode "disable wrtie zero" can fix this issue and Sk Hynix has been verified.
>
> Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>

For the changelog, let's abbreviate the subject to something like:

  "nvme-pci: disable write zeroes for SK Hynix BC901"

> @@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
>               .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>       { PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
>               .driver_data = NVME_QUIRK_BOGUS_NID, },
> +     { PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
> +             .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },

Could we get an "Ack" from the vendor?
------------------------------------------------------------------------------------------------------------------------------------------------------------

-----Original Message-----
From: Jim.Lin <jim.chihjung.lin@gmail.com>
Sent: Tuesday, November 28, 2023 10:58 AM
To: kbusch@kernel.org
Cc: axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; Jim Lin 林志融 <jim.lin@siliconmotion.com>; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; hardaway.tseng@sk.com
Subject: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Please note that this email was sent from outside of SMI.

SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode "disable write zeroes" can fix this issue and Sk Hynix has been verified.

Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 507bc149046d..f27202680741 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
                .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
                .driver_data = NVME_QUIRK_BOGUS_NID, },
+       { PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
+               .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x15b7, 0x2001),   /*  Sandisk Skyhawk */
                .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
        { PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
--
2.25.1

********************************************************************************
CONFIDENTIALITY AND PROPRIETARY NOTICE: ALL RIGHTS RESERVED.
The information in this message (and any attachments) may contain confidential or proprietary information of the sender, her/his representing company, and its affiliated companies, and is private, privileged and confidential. It is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended and/or designated recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, saving, forwarding or copying of this message (including its attachments) is strictly prohibited. If you have received this email communication in error, please notify the sender immediately and delete this communication entirely and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies from your computer or any device) to avoid any legal problems. Thank you for your cooperation.
********************************************************************************
機密性及專有性警語：版權所有。
此電子郵件及其所有附件(如有之)所含之資訊可能含有寄件者及其所代表公司和其關係企業的機密資訊。除本電子郵件傳送之指定及/或特定對象，其他人非經寄件者許可不得揭露、複製、散佈本郵件及其所有附件。若您非此郵件被指定及/或特定的收件者，或誤收，或在任何原因未經授權的情形下收到本郵件，請勿揭曉本郵件內容予任何人，並即通知原寄件者，亦請自您的電腦完全刪除此信件和任何已列印之文件，以免徒增不必要之法律困擾。謝謝您的合作。

Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[Keith Busch]

On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@sk.com wrote:
> Hi Keith, Jim and team,
> 
> Thanks for efforts!
> 
> This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Great, thanks for confirming. I've got this queued up internally, but
want to check if Christoph's question could lead to a better outcome for
everyone. For reference, asked here:

  https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html

If you were already testing close to upstream, 6.2 or newer, then this
patch is already the best option.

RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[hardaway.tseng]

Hi Keith,

Thanks for head up Christoph's questions!
Our team will help us to answer them.

Hi Jim and David,
Thanks for your support!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan
Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Keith Busch <kbusch@kernel.org> 
Sent: Wednesday, November 29, 2023 8:10 AM
To: Hardaway (Shih Hung) Tseng SKHYT <hardaway.tseng@sk.com>
Cc: Jim Lin 林志融 <jim.lin@siliconmotion.com>; Jim.Lin <jim.chihjung.lin@gmail.com>; axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@sk.com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@sk.com>
Subject: Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@sk.com wrote:
> Hi Keith, Jim and team,
> 
> Thanks for efforts!
> 
> This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Great, thanks for confirming. I've got this queued up internally, but want to check if Christoph's question could lead to a better outcome for everyone. For reference, asked here:

  https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html

If you were already testing close to upstream, 6.2 or newer, then this patch is already the best option.

RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[hardaway.tseng]

Hi Keith,

Hope everything you are doing is well!

These days our teams tried several way to do further verification of this disable write zero patch for BC901, let me summarize as below :

1)	The chrome image with this new write zero disable code built with 5.15, has been verified and passed (< 20min mode switching time)
2)	Due to some limitations, Google team couldn't build a new chrome image with the suggested 6.5 or later version + this disable write zero patch for verification test.
3)	Tried to build image with 5.15 + disable write zero patch + DEAC merged, system can run but the testing result is failed (> 20min mode switching, actually 27~29mins).

Above is all we could do here for the verification of this patch, could you share us your comment or suggestion?

Thank you so much!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan
Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Hardaway (Shih Hung) Tseng SKHYT 
Sent: Wednesday, November 29, 2023 11:51 AM
To: 'Keith Busch' <kbusch@kernel.org>; Jim Lin 林志融 <jim.lin@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>
Cc: Jim.Lin <jim.chihjung.lin@gmail.com>; axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@sk.com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@sk.com>
Subject: RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Hi Keith,

Thanks for head up Christoph's questions!
Our team will help us to answer them.

Hi Jim and David,
Thanks for your support!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Keith Busch <kbusch@kernel.org>
Sent: Wednesday, November 29, 2023 8:10 AM
To: Hardaway (Shih Hung) Tseng SKHYT <hardaway.tseng@sk.com>
Cc: Jim Lin 林志融 <jim.lin@siliconmotion.com>; Jim.Lin <jim.chihjung.lin@gmail.com>; axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@sk.com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@sk.com>
Subject: Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@sk.com wrote:
> Hi Keith, Jim and team,
> 
> Thanks for efforts!
> 
> This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Great, thanks for confirming. I've got this queued up internally, but want to check if Christoph's question could lead to a better outcome for everyone. For reference, asked here:

  https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html

If you were already testing close to upstream, 6.2 or newer, then this patch is already the best option.

RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[hardaway.tseng]

Hello Keith,

Hope everything you are doing is well!

These days our teams tried several way to do further verification of this disable write zero patch for BC901, let me summarize as below :

1)	The chrome image with this new write zero disable code built with 5.15, has been verified and passed (< 20min mode switching time)
2)	Due to some limitations, Google team couldn't build a new chrome image with the suggested 6.5 or later version + this disable write zero patch for verification test.
3)	Tried to build image with 5.15 + disable write zero patch + DEAC merged, system can run but the testing result is failed (> 20min mode switching, actually 27~29mins).

Above is all we could do here for the verification of this patch, could you share us your comment or suggestion? Is it possible to merge and do upstream for this patch?

Thank you so much!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”

Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan
Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Hardaway (Shih Hung) Tseng SKHYT 
Sent: Wednesday, November 29, 2023 11:51 AM
To: 'Keith Busch' <kbusch@kernel.org>; Jim Lin 林志融 <jim.lin@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>
Cc: Jim.Lin <jim.chihjung.lin@gmail.com>; axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@sk.com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@sk.com>
Subject: RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Hi Keith,

Thanks for head up Christoph's questions!
Our team will help us to answer them.

Hi Jim and David,
Thanks for your support!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@sk.com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Keith Busch <kbusch@kernel.org>
Sent: Wednesday, November 29, 2023 8:10 AM
To: Hardaway (Shih Hung) Tseng SKHYT <hardaway.tseng@sk.com>
Cc: Jim Lin 林志融 <jim.lin@siliconmotion.com>; Jim.Lin <jim.chihjung.lin@gmail.com>; axboe@kernel.dk; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; CJ Chen 陳群傑 <cj.chen@siliconmotion.com>; David Yeh 葉寰融 <david.yeh@siliconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@sk.com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@sk.com>
Subject: Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@sk.com wrote:
> Hi Keith, Jim and team,
> 
> Thanks for efforts!
> 
> This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Great, thanks for confirming. I've got this queued up internally, but want to check if Christoph's question could lead to a better outcome for everyone. For reference, asked here:

  https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html

If you were already testing close to upstream, 6.2 or newer, then this patch is already the best option.

Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[Christoph Hellwig]

On Tue, Nov 28, 2023 at 10:57:37AM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
> "disable write zeroes" can fix this issue and Sk Hynix has been verified.

Did you test this on an upstream kernel with

ommit 1b96f862ecccb3e6f950eba584bebf22955cecc5
Author: Christoph Hellwig <hch@lst.de>
Date:   Sun Oct 30 16:50:15 2022 +0100

    nvme: implement the DEAC bit for the Write Zeroes command

included?  Or in ther words, does this drive not implement DEAC
or does it not work properly?  What are the chances of actually
fixing the fimware to work properly?  Also WZSL limit does the
drive report?

Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

[Keith Busch]

On Tue, Nov 28, 2023 at 10:57:37AM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
> "disable write zeroes" can fix this issue and Sk Hynix has been verified.
> 
> Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>

Thanks, applied to nvme-6.8.