From: James Swaro <j.swaro@samsung.com>
To: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Karl Bonde Torp <k.torp@samsung.com>, "os@safl.dk" <os@safl.dk>
Subject: NVMe Target implementation question
Date: Mon, 9 Nov 2026 11:01:15 +0000 [thread overview]
Message-ID: <d5526bf8ab18484e9646fda8aa765aa6@samsung.com> (raw)
In-Reply-To: CGME20261109110115exchanged5526bf8ab18484e9646fda8aa765aa6@eucas1p1.samsung.com
Hi everyone,
I'm writing an NVMe initiator implementation and noticed an oddity in the kernel target implementation. When initializing a request structure in the target for a received message (drivers/nvme/target/core.c:966), the driver is checking whether the flags are set to SGL_METABUF and returning an error if it isn't set to SGL_METABUF. This seems to be incorrect according to the specification, so I wanted to get clarification here first.
According to the NVMe 2.4 Base Specification, section 6.5 & 6.6 (Property semantics), byte 1 containing the PDST/flags is supposed to be cleared to 0h. When clearing that byte on the initiator, this causes the target to return with an invalid command and DNR=1. Is this a case of legacy behavior being preserved from older specifications? Is there some part of the specification which contradicts this that I missed?
Kind regards,
James Swaro
Samsung SDS
parent reply other threads:[~2026-11-09 17:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CGME20261109110115exchanged5526bf8ab18484e9646fda8aa765aa6@eucas1p1.samsung.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5526bf8ab18484e9646fda8aa765aa6@samsung.com \
--to=j.swaro@samsung.com \
--cc=k.torp@samsung.com \
--cc=linux-nvme@lists.infradead.org \
--cc=os@safl.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox