From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C113FC33CAF for ; Wed, 22 Jan 2020 17:25:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 942522465B for ; Wed, 22 Jan 2020 17:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M73cI3fq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 942522465B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wk2NIeWuDrz6VQC9Os7A/D0rsHyEScG65hVQgFOk4+A=; b=M73cI3fqYA0CuE jFBdFcdvn7qzBxjLXMI37zST2/t6XF7neStoMOeTQqBU0n3l+7HbOGp3V2+BjccGxpU9Ac29xSSz+ CH5DA1giUcZz1JnmMAcunAJlUn8BojqFKuAyPce0xqWM7WPSn7BT0Yuh54vt7jXqvfUxoWX1j4wW2 PwIwgpOuMQyMnVCX8Zl/enwJwB8INCtaYDmfnmulBQg7vs2Q8nZE4+70eqTlYT0T/0bFgrJnTJHje DWAR9KBPaDJ9WiCxH9R8habxx8kSRs8Ana5tb/P+8rsq7KObX+DuyFFvbrvdVby4BodjoiRIeV70w MZZjjyTYgFni6lxP9HXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuJl0-0004SJ-LB; Wed, 22 Jan 2020 17:25:34 +0000 Received: from mga06.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuJku-0004OB-Mg for linux-nvme@lists.infradead.org; Wed, 22 Jan 2020 17:25:32 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 09:25:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,350,1574150400"; d="scan'208";a="400074140" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga005.jf.intel.com with ESMTP; 22 Jan 2020 09:25:27 -0800 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jan 2020 09:25:27 -0800 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.100]) by ORSMSX112.amr.corp.intel.com ([169.254.3.36]) with mapi id 14.03.0439.000; Wed, 22 Jan 2020 09:25:27 -0800 From: "Derrick, Jonathan" To: "linux-nvme@lists.infradead.org" Subject: Re: [PATCH] nvme/pci: Add sleep quirk for Samsung and Toshiba drives Thread-Topic: [PATCH] nvme/pci: Add sleep quirk for Samsung and Toshiba drives Thread-Index: AQHV0JE8PJxAY0HnKU6GNvS3A/cVVaf3dteA Date: Wed, 22 Jan 2020 17:25:26 +0000 Message-ID: References: <20200121193012.29360-1-jonathan.derrick@intel.com> In-Reply-To: <20200121193012.29360-1-jonathan.derrick@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.4.211] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200122_092528_810839_2BB51528 X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "N, Shyjumon" , "sagi@grimberg.me" , "axboe@fb.com" , "Nadolski, Edmund" , "kbusch@kernel.org" , "hch@lst.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, 2020-01-21 at 12:30 -0700, Jon Derrick wrote: > From: shyjumon > > From: Shyjumon N > > The Samsung SSD SM981/PM981 and Toshiba SSD KBG40ZNT256G on the Lenovo > C640 platform experience runtime resume issues when the SSDs are kept in > sleep/suspend mode for long time. > > This patch applies the 'Simple Suspend' quirk to these configurations. > With this patch, the issue had not been observed in a 1+ day test. > > Signed-off-by: Jon Derrick > [jonathan.derrick: fix up commit message] > Signed-off-by: Shyjumon N Sorry the signoff ordering is reversed here. Should be Shyjumon first. That being said, I wonder if there's something else the driver should be doing for the whole range of devices and platform combos that seem to require similar pm quirks. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme